Bump up Instant60 custom EEPROM offsets to avoid conflict #6906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Instant60 PCB supports Via (not sure if this is official, since it wasn't updated with the other Via PCBs), and it has the same address conflict that the other Via-supported PCBs did. This leads to weirdness with Ctrl and Super keys swapping. I'm bumping the EEPROM offsets to fix this issue.
Tested on my Instant60 PCB with both non-Via and Via keymaps. No key swapping in either case. For Via keymap, I was able to edit in keycodes and they worked fine.
@awkannan, it looks like the AN-C 60% PCB needs the same fix, but I don't have a physical one of these to test. I can send a PR for it (seems to be the same basic PCB, just not hotswap), but am a bit nervous making an untested change like that. Let me know if you'd like me to do this.
Questions: Should I bump the
EEPROM_MAGIC
for this board (it has a custom value) to force an EEPROM reset after this change? And does this need to go out via the breaking changes process? It seems like maybe it should... but this keyboard is already broken due to the Ctrl/Super swap, and it seems like the other EEPROM offset fixes were rolled out immediately, so maybe not?Types of Changes
Issues Fixed or Closed by This PR
Checklist