Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up Instant60 custom EEPROM offsets to avoid conflict #6906

Closed
wants to merge 2 commits into from
Closed

Bump up Instant60 custom EEPROM offsets to avoid conflict #6906

wants to merge 2 commits into from

Conversation

bcat
Copy link
Contributor

@bcat bcat commented Oct 5, 2019

  • The Instant60 PCB supports Via (not sure if this is official, since it wasn't updated with the other Via PCBs), and it has the same address conflict that the other Via-supported PCBs did. This leads to weirdness with Ctrl and Super keys swapping. I'm bumping the EEPROM offsets to fix this issue.

  • Tested on my Instant60 PCB with both non-Via and Via keymaps. No key swapping in either case. For Via keymap, I was able to edit in keycodes and they worked fine.

  • @awkannan, it looks like the AN-C 60% PCB needs the same fix, but I don't have a physical one of these to test. I can send a PR for it (seems to be the same basic PCB, just not hotswap), but am a bit nervous making an untested change like that. Let me know if you'd like me to do this.

  • Questions: Should I bump the EEPROM_MAGIC for this board (it has a custom value) to force an EEPROM reset after this change? And does this need to go out via the breaking changes process? It seems like maybe it should... but this keyboard is already broken due to the Ctrl/Super swap, and it seems like the other EEPROM offset fixes were rolled out immediately, so maybe not?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awkannan Any issues with this?

@bcat
Copy link
Contributor Author

bcat commented Oct 7, 2019

So I asked on CannonKeys Discord and it seems they have another PR for this. I can close this one then.

@bcat bcat closed this Oct 7, 2019
@bcat bcat deleted the bcat_instant60 branch October 17, 2019 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants