Userspace refactor, adding leader key functionality #7790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curry
commented
Jan 4, 2020
drashna
approved these changes
Jan 4, 2020
Curry
force-pushed
the
user_curry_refactor
branch
2 times, most recently
from
35d913b to
1152ee5
Compare
|
Rebased with master to hopefully have CI build pass |
Curry
force-pushed
the
user_curry_refactor
branch
from
b5ea9a3 to
45ae34d
Compare
|
Thanks! |
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
* Userspace refactor * Fixed missed ifdef * tapcode16, adjust layout * glcdfont changes from qmk#7745 * Modify Keymaps, add workman * RGB & OLED update
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* Userspace refactor * Fixed missed ifdef * tapcode16, adjust layout * glcdfont changes from qmk#7745 * Modify Keymaps, add workman * RGB & OLED update
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Userspace refactor * Fixed missed ifdef * tapcode16, adjust layout * glcdfont changes from qmk#7745 * Modify Keymaps, add workman * RGB & OLED update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating my userspace that was recently commited to be more uniform, as well as fix a couple of problems that I missed the first time through.
matrix_scan_userto leader.cTypes of Changes
Checklist
Comments
I refactored most of the header files in my userspace to use least amount of
#includes. If this is not a practice that you guys enforce, and prefer me to put as many includes as possible in the headers to simplify the includes in the source file, let me know and I will change them.