Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PauliOp * PauliOp doesn't deduplicate the result #67

Open
jamesETsmith opened this issue Oct 7, 2024 · 0 comments
Open

PauliOp * PauliOp doesn't deduplicate the result #67

jamesETsmith opened this issue Oct 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jamesETsmith
Copy link
Contributor

General

The PauliOp times PauliOp implementation doesn't deduplicate the final list of PauliStrings in the resulting PauliOp. For performance reasons, we add in this deduplication, for now the resulting PauliOps are still correct,

Details

See the implementation here

friend PauliOp<T, H> operator*(PauliOp<T, H> const &lhs, PauliOp<T, H> const &rhs)
{

@jamesETsmith jamesETsmith added the enhancement New feature or request label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant