Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bunch of methods acting on abstract types assume internal layout for these types #12

Open
Krastanov opened this issue Jun 14, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Krastanov
Copy link
Collaborator

E.g.:

Long term, a better design would be to move these to QuantumOpticsBase where they will act on concrete (not abstract) types (this is where they came from). Methods acting on abstract types should use only public APIs, not assumptions about internal layout, because the internal layout might be different in other libraries extending this functionality. E.g. QuantumClifford.PauliChannel superoperators do not have basis_l slots, unlike QuantumOptics superoperators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant