Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual editors compatibility #27

Open
herrvigg opened this issue Jun 21, 2018 · 13 comments
Open

Visual editors compatibility #27

herrvigg opened this issue Jun 21, 2018 · 13 comments
Labels
enhancement New feature or request legacy issue Legacy issue imported from original repo

Comments

@herrvigg
Copy link
Collaborator

Issue by johnclause
Friday Feb 20, 2015 at 23:14 GMT
Originally opened as qTranslate-Team/qtranslate-x#27


Hi Michel (@mweimerskirch), I am wondering, since you seem pretty familiar with both codes, mq- and -x, could you take a look at the problem with WP Editor https://wordpress.org/plugins/wp-editor/? Users report, https://wordpress.org/support/topic/wp-edit-modifying-pages-in-visual-mode-not-working, it working in mq-, while it not working in -x. Would you be able and have time to look for a reason? I would not expect a fix to be easy, but at least understanding the reason why it does not work in -x would be a good start. Thanks a lot in any case for all your help.

@herrvigg herrvigg added enhancement New feature or request legacy issue Legacy issue imported from original repo labels Jun 21, 2018
@herrvigg
Copy link
Collaborator Author

Comment by mweimerskirch
Saturday Feb 21, 2015 at 11:06 GMT


I had a look at WP Editor. For starters, it doesn't work with mqTranslate either (at least for me). :-)
"codemirror" (the editor component that they are using) should automatically detect any changes on the "#content" textarea (through "change" events as well as through polling (every 100ms)). I'm not sure why that doesn't work, but the have bundled a pretty old version (2.33, whereas the current version is 5.0). So it could be a bug in their code.

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Saturday Feb 21, 2015 at 15:43 GMT


Yes, that was my experience too, when I tried it under mq. I do not know how it works for them. Thanks for the notes, it is already helpful.

@herrvigg
Copy link
Collaborator Author

Comment by mweimerskirch
Monday Feb 23, 2015 at 22:10 GMT


I had another look at WP Editor. Even with qtranslate-X disabled, WP-Editor does not detect external changes to the #content field. you can try this by selecting the #content field in the inspector, making it visible again and typing into it. This is clearly a bug in their code. IMHO, you can close this issue, because there is nothing you can do in qtranslate-X.

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Tuesday Feb 24, 2015 at 00:47 GMT


I meant this thread for all Visual Whatever. Many people keep talking about some 'Visual Composer', which I do not even have to try ... But the solution, if we come up with some, will be probably similar.

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Wednesday Mar 04, 2015 at 19:19 GMT


Michel, I noticed that "Visual Composer" actually works well with mq, while does not work with -X. Did you ever work on js code of mq? Would you happen to know what is the major difference which makes it work for mq? Codes are quite different now. -X inherited it from zTranslate, and I never learned how original q and mq do this. After a quick look, it seems to me that mq has multiple copies of tinymce instances for each language, is that correct? I also notices that mq takes considerably longer to load, and multiple copies might be a reason? Are those multiple copies is what helps to "Visual Composer"? Any other ideas?

@herrvigg
Copy link
Collaborator Author

Comment by mweimerskirch
Wednesday Mar 04, 2015 at 20:14 GMT


I don't know the code from (m)qTranslate that well, but we use Visual Composer for one of our clients. It has two specific files that work as compatibility layer. One for qTranslate and one for mqTranslate. They both contain some JavaScript code. They also check if the corresponding plugins are active using "is_plugin_active( 'qtranslate/qtranslate.php' )

@herrvigg
Copy link
Collaborator Author

Comment by bekatoros
Sunday Mar 08, 2015 at 09:15 GMT


Do you need version 4.3.5 of js_composer (Visual Composer)?

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Sunday Mar 08, 2015 at 21:20 GMT


Yes, it would help. qtranslateteam a t gm ail d c om. Marios, do you have an account with Visual Composer? If they made it work with qTranslate, maybe they will now help to make it work with -X? If you have an account, then, as a valid active user, you could suggest it to them, could you?

@herrvigg
Copy link
Collaborator Author

Comment by bekatoros
Monday Mar 09, 2015 at 07:03 GMT


It was bundled with a theme but I opened a ticket in the theme Creator page.
In wpbakery i see that they added support for mqtranslate 29.07.2014 - ver 4.3 New: Added support for mqTranslate (qTranslate fork which works with WP 3.9+)
https://wpbakery.atlassian.net/wiki/display/VC/Release+Notes

@herrvigg
Copy link
Collaborator Author

Comment by bekatoros
Monday Mar 09, 2015 at 15:19 GMT


The theme creator opened a ticket to Visual Composer so, I hope they will add support soon.

@herrvigg
Copy link
Collaborator Author

Comment by bekatoros
Tuesday Mar 10, 2015 at 07:38 GMT


Here is the response from VisualComposer support:

"We had actually investigated this issue. Our development team has found the problem and they think it is possible to solve it somehow. But such kind of bugs breaks our code. They have created a try/catch block with ability to display simple textarea instead of tinymce with a text message about problems with a working tinymce. This will be available in the next update. Because plugins such as qTranslate, qtranslate plus make very huge changes in js with every release, it is really difficult to build custom code for every version."

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Tuesday Mar 10, 2015 at 17:34 GMT


That is why we had better to come up with a high level interface, which would allow to integrate with a custom tinymce in a simple way. Once this is designed we can ensure that this high level interface stays functioning from update to update. However, I currently have a vague idea what is actually needed. It would be awesome to coordinate this kind of design with them. Could you suggest their designers to write to qtranslateteam a t g ma il d c om to establish a contact?

@herrvigg
Copy link
Collaborator Author

Comment by bekatoros
Wednesday Mar 11, 2015 at 06:48 GMT


I don't have direct access either. The best thing you can do is leave a message in codecanyon to get in contact with you. http://codecanyon.net/item/visual-composer-page-builder-for-wordpress/242431/comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request legacy issue Legacy issue imported from original repo
Projects
None yet
Development

No branches or pull requests

1 participant