Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of .squiggle selector in squiggle-components #1892

Closed
berekuk opened this issue Jun 3, 2023 · 1 comment · Fixed by #1894
Closed

Get rid of .squiggle selector in squiggle-components #1892

berekuk opened this issue Jun 3, 2023 · 1 comment · Fixed by #1894
Labels
Web components

Comments

@berekuk
Copy link
Collaborator

berekuk commented Jun 3, 2023

It causes CSS precedence issues when the consumer doesn't use important selector itself.

Instead, we should use the same approach that I used in packages/ui.

Since squiggle-components extends Tailwind's theme, it also means that it should export a Tailwind plugin.
@github-project-automation github-project-automation bot moved this to 🆕 To prioritize in Overview Jun 3, 2023
@berekuk berekuk mentioned this issue Jun 3, 2023
Merged
@berekuk
Copy link
Collaborator Author

berekuk commented Jun 6, 2023

Fixed by #1894.

@berekuk berekuk closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Web components
Projects
Overview
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No Tailwind selectors quantified-uncertainty/squiggle
1 participant
@berekuk