Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also collect Gradle test failures #83

Closed
famod opened this issue Apr 18, 2021 · 5 comments
Closed

Also collect Gradle test failures #83

famod opened this issue Apr 18, 2021 · 5 comments

Comments

@famod
Copy link
Member

famod commented Apr 18, 2021

The actual location in Quarkus main should be:

integration-tests/gradle/build/test-results/test/

Some thing like **/build/test-results/test/TEST-*.xml should catch them.

The first thing that needs to be done is to extend the Upload Surefire reports step but I suppose something needs to be done in the bot as well?

@famod
Copy link
Member Author

famod commented Apr 18, 2021

For cancelled I think we'll also need to add || cancelled() to the if condition: https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#job-status-check-functions

@famod
Copy link
Member Author

famod commented Apr 18, 2021

Good point! I'll try it out.

@gsmet
Copy link
Member

gsmet commented Apr 18, 2021

See quarkusio/quarkus#16251 (comment) for an example of it working.

@famod
Copy link
Member Author

famod commented Apr 18, 2021

Ah, ok. So I guess the only blind spot is cancelled build steps for which the surefire reports are not uploaded yet.
We can adjust that in the main repo without touching the bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants