From c4c57d623f9086da53f62ee75bbcf47f55add8f3 Mon Sep 17 00:00:00 2001 From: Falko Modler Date: Wed, 7 Aug 2024 19:35:07 +0200 Subject: [PATCH] Fix spring-data-jpa @Modifying(clearAutomatically = true) --- .../deployment/ModifyingQueryWithFlushAndClearTest.java | 7 +++---- .../io/quarkus/spring/data/runtime/RepositorySupport.java | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/extensions/spring-data-jpa/deployment/src/test/java/io/quarkus/spring/data/deployment/ModifyingQueryWithFlushAndClearTest.java b/extensions/spring-data-jpa/deployment/src/test/java/io/quarkus/spring/data/deployment/ModifyingQueryWithFlushAndClearTest.java index 4c3a98c3b7af51..572b4abfd42596 100644 --- a/extensions/spring-data-jpa/deployment/src/test/java/io/quarkus/spring/data/deployment/ModifyingQueryWithFlushAndClearTest.java +++ b/extensions/spring-data-jpa/deployment/src/test/java/io/quarkus/spring/data/deployment/ModifyingQueryWithFlushAndClearTest.java @@ -69,9 +69,7 @@ public void testNoAutoFlush() { final User verifyUser = getUser("JOHN"); // processLoginEvents did not see the new login event - final boolean allProcessed = verifyUser.getLoginEvents().stream() - .allMatch(loginEvent -> loginEvent.isProcessed()); - assertThat(allProcessed).describedAs("all LoginEvents are marked as processed").isFalse(); + assertThat(verifyUser.getLoginEvents()).hasSize(0); } @Test @@ -83,8 +81,9 @@ public void testAutoFlush() { repo.processLoginEventsPlainAutoClearAndFlush(); final User verifyUser = getUser("JOHN"); + assertThat(verifyUser.getLoginEvents()).hasSize(1); final boolean allProcessed = verifyUser.getLoginEvents().stream() - .allMatch(loginEvent -> loginEvent.isProcessed()); + .allMatch(LoginEvent::isProcessed); assertThat(allProcessed).describedAs("all LoginEvents are marked as processed").isTrue(); } diff --git a/extensions/spring-data-jpa/runtime/src/main/java/io/quarkus/spring/data/runtime/RepositorySupport.java b/extensions/spring-data-jpa/runtime/src/main/java/io/quarkus/spring/data/runtime/RepositorySupport.java index 64daa3dceb133d..f6c26e52be9c9a 100644 --- a/extensions/spring-data-jpa/runtime/src/main/java/io/quarkus/spring/data/runtime/RepositorySupport.java +++ b/extensions/spring-data-jpa/runtime/src/main/java/io/quarkus/spring/data/runtime/RepositorySupport.java @@ -78,6 +78,6 @@ public static void clear(Class clazz) { } public static void flush(Class clazz) { - Panache.getSession(clazz).clear(); + Panache.getSession(clazz).flush(); } }