Maven Archetype generates hard-coded path

[richiethom]

Describe the bug
The quarkus-amazon-lambda-http-archetype archetype generates a hard-coded path to maven.home in the maven-surefire-plugin plugin declaration:

            <plugin>
                <artifactId>maven-surefire-plugin</artifactId>
                <version>${surefire-plugin.version}</version>
                <configuration>
                    <systemPropertyVariables>
                        <java.util.logging.manager>org.jboss.logmanager.LogManager</java.util.logging.manager>
                        <maven.home>/opt/apache-maven</maven.home>
                    </systemPropertyVariables>
                </configuration>
            </plugin>

Expected behavior
maven.home probably shouldn't be declared at all.

Actual behavior
The following declaration is generated:

<maven.home>/opt/apache-maven</maven.home>

To Reproduce
Steps to reproduce the behavior:

1. Use the Amazon Lambda HTTP guide to generate a project using the artefact quarkus-amazon-lambda-http-archetype version 1.6.0.Final.
2. Open the generated pom.xml
3. Look at the maven-surefire-plugin declaration.

Environment (please complete the following information):

• Output of uname -a or ver: Linux DESKTOP-GJJ95MV 4.19.104-microsoft-standard Switch to the Maven distributed copy of the SubstrateVM annotations #1 SMP Wed Feb 19 06:37:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
• Output of java -version: NA
• GraalVM version (if different from Java): NA
• Quarkus version or git rev: 1.6.0.Final
• Build tool (ie. output of mvnw --version or gradlew --version):

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /home/rich/.sdkman/candidates/maven/current
Java version: 14.0.1, vendor: AdoptOpenJDK, runtime: /home/rich/.sdkman/candidates/java/14.0.1.hs-adpt
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "4.19.104-microsoft-standard", arch: "amd64", family: "unix"

Additional context
Note that Maven is not installed in the /opt/apache-maven directory, it is managed by SDKMan

[quarkusbot]

/cc @quarkusio/devtools

[famod]

Thanks for reporting this.

First quick feedback: maven.home is supposed to be there, but the placeholder should not be replaced (must happen at runtime instead).

[famod]

Confirmed locally. I'll try to find out why this is happening...

Update: Does not happen with quarkus-azure-functions-http-archetype (countercheck to rule out a general archetype problem).

[famod]

#10829 should fix this.

Workaround: Replace with <maven.home>${maven.home}</maven.home> (exactly like that, placeholder will be resolved at runtime)

[gsmet]

Fixed in #10845 .