Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus 1.7.0.Final gradle plugin hides errors from protoc compilation #11552

Closed
Shohou opened this issue Aug 24, 2020 · 4 comments · Fixed by #12251
Closed

quarkus 1.7.0.Final gradle plugin hides errors from protoc compilation #11552

Shohou opened this issue Aug 24, 2020 · 4 comments · Fixed by #12251
Assignees
Labels
area/gradle Gradle kind/enhancement New feature or request
Milestone

Comments

@Shohou
Copy link

Shohou commented Aug 24, 2020

Description
Gradle build with quarkus plugin and 'io.quarkus:quarkus-grpc' dependency tries to compile protoc files in src/main/proto. It failed for me because of issue #11550 , but finding the real reason wasn't easy task because protoc compilation process errors is not printed anywhere.

Implementation ideas
Gradle should print command before executing it when --debug is passed to the gradle.
protoc process output should get to the console when --debug or even --info is passed to the gradle.

@Shohou Shohou added the kind/enhancement New feature or request label Aug 24, 2020
@quarkusbot
Copy link

/cc @quarkusio/devtools, @glefloch

@quarkusbot quarkusbot added the area/gradle Gradle label Aug 24, 2020
@gsmet
Copy link
Member

gsmet commented Aug 24, 2020

/cc @michalszynkiewicz

@glefloch
Copy link
Member

We have the same issue with docker logs and native image builds. I think @jaikiran has done something in order to show native build logs.

@jaikiran
Copy link
Member

I had a look and @glefloch is right. This is a similar issue as the one we fixed in #10137. I'll see how easy it is to pass the context of which build tool is initiating this code gen, in this part of the code, so that I can reuse this or similar logic here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gradle Gradle kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants