Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Mutiny 0.8.0 #11614

Closed
1 task
cescoffier opened this issue Aug 25, 2020 · 15 comments · Fixed by #12213
Closed
1 task

Integrate Mutiny 0.8.0 #11614

cescoffier opened this issue Aug 25, 2020 · 15 comments · Fixed by #12213

Comments

@cescoffier
Copy link
Member

Description

Mutiny 0.8.0 is coming soon, and it will require a bit of integration code:

  • Integrate the dropped exception hook

@jponge volunteered to implement this once Mutiny 0.8.0 is released!

@cescoffier cescoffier added the kind/enhancement New feature or request label Aug 25, 2020
@jponge
Copy link
Member

jponge commented Aug 25, 2020

🥳

@Sanne
Copy link
Member

Sanne commented Aug 25, 2020

@gavinking could you look at impact on Hibernate Reactive? Thanks!

@gavinking
Copy link

OK will do.

@gavinking
Copy link

Does Mutiny have a snapshot repo?

@cescoffier
Copy link
Member Author

cescoffier commented Aug 25, 2020

@gavinking yes: https://oss.sonatype.org/content/repositories/snapshots/io/smallrye/reactive/.
As for quarkus, version is 999-SNAPSHOT.

@gavinking
Copy link

Thanks. Well, I just ran the HR tests on 999-SNAPSHOT and nothing broke ... so that's a good start!

@gavinking
Copy link

And I was able to remove all the onItem() calls...

@gavinking
Copy link

And I was able to remove all the onItem() calls...

... and most of the onTermination() calls. Great!

@jponge
Copy link
Member

jponge commented Aug 31, 2020

@cescoffier perhaps we should also integrate a caller thread check for Vert.x event-loops and blocking calls?

@cescoffier
Copy link
Member Author

Yes, the blocking code check is going to help a lot.

@jponge
Copy link
Member

jponge commented Sep 17, 2020

  • Dropped exception hook
  • Blocking thread checker
  • Update documentation references to deprecated APis

@jponge
Copy link
Member

jponge commented Sep 17, 2020

I have an integration for the exception hook, see the WIP branch at https://github.com/jponge/quarkus/tree/mutiny-0.8.0

@jponge
Copy link
Member

jponge commented Sep 17, 2020

Regarding the blocked thread checker: are there other kind of threads than Vert.x event loops in Quarkus that cannot be blocked?

@cescoffier
Copy link
Member Author

No, just check if it’s en event loop (VertxThread won’t be enough)

@jponge
Copy link
Member

jponge commented Sep 20, 2020

I haven't spotted documentation with deprecated APIs. That being said it'd be easier if snippets were included from actual sources like we do in Vert.x, so we could more easily track changes when APis move.

@jponge jponge mentioned this issue Sep 20, 2020
@gsmet gsmet added this to the 1.9.0 - master milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants