Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NativeImageMojo in 1.13 #14645

Closed
4 tasks done
famod opened this issue Jan 27, 2021 · 3 comments · Fixed by #14982
Closed
4 tasks done

Remove NativeImageMojo in 1.13 #14645

famod opened this issue Jan 27, 2021 · 3 comments · Fixed by #14982
Assignees
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/maven
Milestone

Comments

@famod
Copy link
Member

famod commented Jan 27, 2021

Description
As discussed here, NativeImageMojo was deprecated a long time ago and shall therefore be removed.
quarkus.package.type=native is the way to go, see https://quarkus.io/guides/building-native-image

Implementation ideas

[1] Remaining usages:

$ grep -Rl --exclude-dir=.git --exclude-dir=target '<goal>native-image</goal>'
devtools/maven/src/main/resources/create-extension-templates/integration-test-pom.xml
docs/src/main/asciidoc/tika.adoc
extensions/amazon-lambda/maven-archetype/src/main/resources/archetype-resources/pom.xml
extensions/amazon-lambda-http/maven-archetype/src/main/resources/archetype-resources/pom.xml
extensions/funqy/funqy-amazon-lambda/maven-archetype/src/main/resources/archetype-resources/pom.xml
integration-tests/container-image/maven-invoker-way/src/it/container-build-docker/pom.xml
integration-tests/container-image/maven-invoker-way/src/it/container-build-jib/pom.xml
integration-tests/container-image/maven-invoker-way/src/it/container-build-multiple-tags-docker/pom.xml
integration-tests/container-image/maven-invoker-way/src/it/container-build-multiple-tags-jib/pom.xml
integration-tests/container-image/maven-invoker-way/src/it/container-image-push/pom.xml
integration-tests/kotlin/src/test/resources/projects/classic-kotlin/pom.xml
integration-tests/kubernetes/maven-invoker-way/src/it/kubernetes-docker-build-and-deploy/pom.xml
integration-tests/kubernetes/maven-invoker-way/src/it/kubernetes-jib-build-and-deploy/pom.xml
integration-tests/kubernetes/maven-invoker-way/src/it/kubernetes-with-existing-manifest/pom.xml
integration-tests/kubernetes/maven-invoker-way/src/it/openshift-docker-build-and-deploy/pom.xml
integration-tests/kubernetes/maven-invoker-way/src/it/openshift-s2i-build-and-deploy/pom.xml
integration-tests/kubernetes/src/it/openshift-s2i-build-and-deploy/pom.xml
integration-tests/maven/src/test/resources/expected/create-extension-pom-itest/integration-tests/itest/pom.xml
integration-tests/maven/src/test/resources/projects/arc-exclude-dependencies/runner/pom.xml
integration-tests/maven/src/test/resources/projects/classic/pom.xml
integration-tests/maven/src/test/resources/projects/classic-no-build/pom.xml
integration-tests/maven/src/test/resources/projects/classic-no-generate/pom.xml
integration-tests/maven/src/test/resources/projects/classic-no-undertow/pom.xml
integration-tests/maven/src/test/resources/projects/classic-noconfig/pom.xml
integration-tests/maven/src/test/resources/projects/classic-remote-dev/pom.xml
integration-tests/maven/src/test/resources/projects/classic-resource-filtering/pom.xml
integration-tests/maven/src/test/resources/projects/dependency-on-pom/pom.xml
integration-tests/maven/src/test/resources/projects/multimodule/runner/pom.xml
integration-tests/maven/src/test/resources/projects/multimodule-classpath/runner/pom.xml
integration-tests/maven/src/test/resources/projects/multimodule-revision-prop/runner/pom.xml
integration-tests/maven/src/test/resources/projects/multimodule-root-no-src/runner/pom.xml
integration-tests/maven/src/test/resources/projects/native-image-app/pom.xml
integration-tests/maven/src/test/resources/projects/project-with-extension/runner/pom.xml
integration-tests/maven/src/test/resources/projects/property-overrides/runner/pom.xml
integration-tests/maven/src/test/resources/projects/quarkus-index-dependencies/runner/pom.xml
integration-tests/maven/src/test/resources/projects/quarkus.package.output-directory/pom.xml
integration-tests/maven/src/test/resources/projects/rr-with-json-logging/pom.xml
integration-tests/maven/src/test/resources/projects/uberjar-check/pom.xml
integration-tests/maven/src/test/resources/projects/uberjar-maven-plugin-config/pom.xml
integration-tests/neo4j/README.md
integration-tests/scala/src/test/resources/projects/classic-scala/pom.xml
@famod famod added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jan 27, 2021
@ghost
Copy link

ghost commented Jan 27, 2021

@famod famod added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven and removed area/container-image area/funqy area/kotlin area/kubernetes labels Jan 27, 2021
@famod famod self-assigned this Jan 27, 2021
@famod
Copy link
Member Author

famod commented Jan 27, 2021

I'll have a look at the remaining usages.

@famod
Copy link
Member Author

famod commented Jan 27, 2021

#14649 removes the remaining usages. Last part of this issue must wait until development for 1.13 starts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/maven
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant