mvn quarkus:add-extension broken always adding bom

[ia3andy]

Describe the bug

Even when the bom is already present, the quarkus:add-extension adds the bom to the project again.

mvn quarkus:add-extension -Dextensions=resteasy-jackson                                                        127 master!?
executing mvnw instead of mvn
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------< io.lavajug:lavajug-quarkus-todo >-------------------
[INFO] Building lavajug-quarkus-todo 1.0.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- quarkus-maven-plugin:1.13.0.Final:add-extension (default-cli) @ lavajug-quarkus-todo ---
[SUCCESS] ✅ Extension io.quarkus:quarkus-bom has been installed
[SUCCESS] ✅ Extension io.quarkus:quarkus-resteasy-jackson has been installed
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.400 s
[INFO] Finished at: 2021-04-06T11:32:38+02:00
[INFO] ------------------------------------------------------------------------

Resulting in twice the same bom in the pom.xml:

  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>${quarkus.platform.group-id}</groupId>
        <artifactId>${quarkus.platform.artifact-id}</artifactId>
        <version>${quarkus.platform.version}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
      <dependency>
        <groupId>io.quarkus</groupId>
        <artifactId>quarkus-bom</artifactId>
        <version>1.13.0.Final</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>

Expected behavior

It should not add the bom when already present

To Reproduce

Create a base project https://code.quarkus.io/d

Use the command:

mvn quarkus:add-extension -Dextensions=resteasy-jackson  

This also affect the CLI (qs add resteasy-jackson)

[ia3andy]

FYI: when switching quarkus.platform.artifact-id from quarkus-universe-bom to quarkus-bom:

<quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>

Then it doesn't add it anymore, but it's still wrong to add it with the universe bom..

[gsmet]

@aloubyansky I thought you had fixed this one already?

[aloubyansky]

@gsmet it was related but different. It was for 1.11.x, it's on different JSON format. In 1.13.x extensions may have multiple platform origins in the JSON.

[famod]

@aloubyansky does this have anything to do with #14164?

[aloubyansky]

Right, that should be fixed with this one as well, assuming the parent imports the BOM that includes the extension being added.

[famod]

Sounds good, will assign it to you then.