Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smallrye.config.locations property didn't work on 2.0.0.CR2 #17525

Closed
loicmathieu opened this issue May 28, 2021 · 8 comments · Fixed by #17897
Closed

smallrye.config.locations property didn't work on 2.0.0.CR2 #17525

loicmathieu opened this issue May 28, 2021 · 8 comments · Fixed by #17897
Assignees
Labels
area/config area/smallrye env/windows Impacts Windows machines kind/bug Something isn't working
Milestone

Comments

@loicmathieu
Copy link
Contributor

Describe the bug

Using the smallrye.config.locations property didn't works on 2.0.0.CR2 but the new quarkus.config.locations do works.

Expected behavior

Both property works

Environment (please complete the following information):

Output of uname -a or ver

Microsoft Windows [version 10.0.19042.964]

Output of java -version

openjdk version "16" 2021-03-16

Quarkus version or git rev

2.0.0.CR2

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.6.3

@loicmathieu loicmathieu added the kind/bug Something isn't working label May 28, 2021
@quarkus-bot quarkus-bot bot added area/smallrye env/windows Impacts Windows machines labels May 28, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 28, 2021

@loicmathieu
Copy link
Contributor Author

/cc @radcortez

@radcortez
Copy link
Member

Strange. I was not able to reproduce. Do you mind proving me a reproducer? Maybe something else is messing up.

@radcortez
Copy link
Member

BTW, the relocation was added here: ff0dfd4, so since 1.13.x without any apparent issue.

@loicmathieu
Copy link
Contributor Author

I was running 1.13 previously so it's definitly something going on with Quarkus 2.0.
More info on this, I use a property inside of one of those external config file and inject it inside a Java class via @ConfigProperty, I don't know if it is the scenario you tested.
I'll try to make a reproducer later this week if I found the time.

@radcortez
Copy link
Member

Check this one:
radcortez/quarkus-playground@907e27e

Test runs fine. Also in dev mode with mvn quarkus:dev -Dsmallrye.config.locations=config.properties. I'm probably missing something :)

@loicmathieu
Copy link
Contributor Author

Here is a reproducer, using 2.0.0.CR3.
smallrye-config-external-issue.zip

Running the reproducer with smallrye.config.locations show an error in the logs that no upstream subscriber is defined. Using quarkus.config.locations all works fine.

I use smallrye reactive messaging Kafka in my reproducer as it's the framework that I use in my component, so maybe the issue is in the way the Kafka connector is configured

@radcortez
Copy link
Member

Added a fix. The issue only occurred in some specific cases, where a quarkus.config.locations was recorded in build time from smallrye.config.locations.

@radcortez radcortez self-assigned this Jun 17, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 21, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/smallrye env/windows Impacts Windows machines kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants