Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle wrapper to 7.0 or greater #19256

Closed
pjgg opened this issue Aug 5, 2021 · 8 comments · Fixed by #17102
Closed

Upgrade Gradle wrapper to 7.0 or greater #19256

pjgg opened this issue Aug 5, 2021 · 8 comments · Fixed by #17102
Labels
area/gradle Gradle kind/enhancement New feature or request
Milestone

Comments

@pjgg
Copy link
Contributor

pjgg commented Aug 5, 2021

Description

Currently, Gradle 6.9 has some limitations as not being able to define exclusiveContent

Gradle also lets you declare exclusive content that can only be found in one repository and it shouldn’t be searched for in any other.

This is especially useful to avoid "A confusing dependency" than then later could finish in some security vulnerabilities.

Implementation ideas

Upgrade gradle distribution to something greater or equal to 7

https://github.com/quarkusio/quarkus/blob/main/devtools/gradle/gradle/wrapper/gradle-wrapper.properties#L3

@pjgg pjgg added the kind/enhancement New feature or request label Aug 5, 2021
@quarkus-bot quarkus-bot bot added the area/gradle Gradle label Aug 5, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 5, 2021

/cc @glefloch, @quarkusio/devtools

@pjgg
Copy link
Contributor Author

pjgg commented Aug 9, 2021

@geoand WDYT ?

@glefloch
Copy link
Member

glefloch commented Aug 9, 2021

@gsmet were you able to check if this can be done ? (IIRC there could have been issues with the support)

@gsmet
Copy link
Member

gsmet commented Aug 9, 2021

I'd say we could prepare a PR and we will merge it either for 2.2 or for 2.3.

@glefloch
Copy link
Member

glefloch commented Aug 9, 2021

Ok I can take care of it next week then.

@gsmet
Copy link
Member

gsmet commented Aug 9, 2021

Cool, thanks!

@gsmet
Copy link
Member

gsmet commented Aug 10, 2021

@glefloch we have the green light to move to Gradle 7 in 2.2 if it helps making progress on the JDK 17 support.

@glefloch
Copy link
Member

Great I will add this in the branch that enable gradle tests on jdk17 once I’m back from PTO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gradle Gradle kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants