Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev UI: Config Editor should render different web components depending on the config property type #19636

Closed
gastaldi opened this issue Aug 25, 2021 · 3 comments · Fixed by #19832
Closed

Dev UI: Config Editor should render different web components depending on the config property type #19636

gastaldi opened this issue Aug 25, 2021 · 3 comments · Fixed by #19832
Assignees
@phillip-kruger
Labels
area/dev-ui good first issue Good for newcomers kind/enhancement New feature or request
Milestone
2.3.0.CR1

Comments

@gastaldi
Copy link
Contributor

Description

It would be nice if number-based properties were displayed as a spinner, enum items as a combo box, boolean as checkboxes, etc.

Implementation ideas

Store the config type in the ConfigDescription value object and check in the template
@gastaldi gastaldi added kind/enhancement New feature or request good first issue Good for newcomers labels Aug 25, 2021
@gastaldi
Copy link
Contributor Author

/cc @phillip-kruger

@gastaldi gastaldi changed the title Dev UI: Config Editor should display different web components depending on the config property type Dev UI: Config Editor should render different web components depending on the config property type Aug 25, 2021
@phillip-kruger
Copy link
Member

Hi @gastaldi - I had the same idea, and actually started to implement it, but I am not sure where to get the type of the config from. Maybe @radcortez can help ?

@phillip-kruger phillip-kruger self-assigned this Sep 1, 2021
@phillip-kruger
Copy link
Member

@gastaldi - I have done this ... PR to follow soon

@phillip-kruger phillip-kruger mentioned this issue Sep 1, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 1, 2021
@jponge jponge mentioned this issue Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillip-kruger phillip-kruger

Labels
area/dev-ui good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Milestone
2.3.0.CR1
2 participants
@gastaldi @phillip-kruger