Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Editor doesn't update the prefixed values #19913

Open
danieloh30 opened this issue Sep 3, 2021 · 9 comments · May be fixed by #43354
Open

Config Editor doesn't update the prefixed values #19913

danieloh30 opened this issue Sep 3, 2021 · 9 comments · May be fixed by #43354
Labels
area/dev-ui kind/bug Something isn't working

Comments

@danieloh30
Copy link

Describe the bug

Found this weird thing. After I defined %dev.username=value1 in the application.properties, I updated the value to value2 via config editor in DEV UI. It turns out Quarkus appended a new key and value like username=daniel without prefix %dev.

Expected behavior

%dev.username=value2

Actual behavior

%dev.username=value1
username=value2

How to Reproduce?

  1. Run "./mvnw quarkus:dev" using 2.2.1.Final
  2. Add the key and value(%dev.username=value1) in the application.properties
  3. Go to DEV UI > Config Editor > Search "username" > Update the value to "value2"
  4. Go back to application.properties

Output of uname -a or ver

Darwin Daniels-MacBook-Pro 20.6.0 Darwin Kernel Version 20.6.0: Wed Jun 23 00:26:31 PDT 2021; root:xnu-7195.141.2~5/RELEASE_X86_64 x86_64

Output of java -version

openjdk version "11.0.10" 2021-01-19 OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.10+9) OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.10+9, mixed mode)

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.2.1.Final

Build tool (ie. output of mvnw --version or gradlew --version)

Maven home: /Users/danieloh/cloud-native-app-dev/tools/apache-maven-3.8.1

Additional information

No response

@danieloh30 danieloh30 added the kind/bug Something isn't working label Sep 3, 2021
@danieloh30 danieloh30 changed the title Config Editor doesn't work with prefixed values Config Editor doesn't update the prefixed values Sep 3, 2021
@geoand
Copy link
Contributor

geoand commented Nov 4, 2022

Do you know if this is still true @phillip-kruger ?

@phillip-kruger
Copy link
Member

Yes that sounds right. I'll have a look a.s.a.p

@geoand
Copy link
Contributor

geoand commented Nov 4, 2022

🙏🏼

@geoand
Copy link
Contributor

geoand commented Sep 20, 2024

Is this still true with all the changes that have now gone into the config editor?

@geoand geoand added the triage/needs-feedback We are waiting for feedback. label Sep 20, 2024
@danieloh30
Copy link
Author

Still same issue in Quarkus 3.14.4

%dev.myname=Dan
myname=Dan2

@danieloh30
Copy link
Author

image

@geoand
Copy link
Contributor

geoand commented Sep 20, 2024

Thanks for checking!

@geoand geoand removed the triage/needs-feedback We are waiting for feedback. label Sep 20, 2024
@phillip-kruger
Copy link
Member

@danieloh30 please check against #43354

@danieloh30
Copy link
Author

LGTM :)

@phillip-kruger phillip-kruger linked a pull request Sep 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-ui kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants