Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI help message contains text for registry add command instead of extension add command #19979

Closed
rsvoboda opened this issue Sep 7, 2021 · 2 comments · Fixed by #20011
Closed
Assignees
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/jbang Issues related to when using jbang.dev with Quarkus kind/bug Something isn't working
Milestone

Comments

@rsvoboda
Copy link
Member

rsvoboda commented Sep 7, 2021

Describe the bug

CLI help message contains text for registry add command instead of extension add command.

There is no add command listed under registry.

jbang app install --force --name qss ~/.m2/repository/io/quarkus/quarkus-cli/999-SNAPSHOT/quarkus-cli-999-SNAPSHOT-runner.jar

qss --help
...
  extension, ext      List, add, and remove extensions of an existing project.
    list, ls          List platforms and extensions.
    categories, cat   List extension categories.
    add               Add a Quarkus extension registry to the registry client
                        configuration
    remove, rm        Remove extension(s) from this project.
  registry            Manage extension registries.
    list              List enabled Quarkus registries
    remove            Remove a Quarkus extension registry from the registry
                        client configuration
  version             Display version information.
  completion          bash/zsh completion:  source <(quarkus completion)

Expected behavior

add sub-command is listed for both extension and registry commands

Actual behavior

add sub-command is listed just for registry command but with text for add sub-command for extension command.

How to Reproduce?

qss --help or quarkus --help

Output of uname -a or ver

macOS BigSur

Output of java -version

Java 11

GraalVM version (if different from Java)

No response

Quarkus version or git rev

main

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

Running qss ext --help and qss registry --help gives correct info.

As if cli had hard time to handle two different sub-commands with the same name = "add".
When I changed value of name attribute to rs in RegistryAddCommand, qss --help message got rendered properly.

@rsvoboda rsvoboda added the kind/bug Something isn't working label Sep 7, 2021
@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/jbang Issues related to when using jbang.dev with Quarkus labels Sep 7, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 7, 2021

/cc @ebullient, @maxandersen, @quarkusio/devtools

@ebullient
Copy link
Member

good catch. Not sure how that happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/jbang Issues related to when using jbang.dev with Quarkus kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants