[CI] - Quarkus Super Heroes + Quarkus main #23612
Comments
quarkus-super-heroes-bot
added
the
triage/ci-participant
|
The build is still failing:
|
|
The build is still failing:
|
|
The build is still failing:
|
|
Build fixed:
|
|
Unfortunately, the build failed:
|
|
The build is still failing:
|
|
@geoand is this a regression on Quarkus main? Error: ] Some problems were encountered while processing the POMs:
Error: 'dependencies.dependency.version' for io.quarkus:quarkus-junit5-vertx:jar is missing. @ line 109, column 17
@
Error: The build could not read 1 project -> [Help 1]
Error:
Error: The project io.quarkus.workshop.super-heroes:rest-heroes:1.0 (/home/runner/work/quarkus-super-heroes/quarkus-super-heroes/current-repo/rest-heroes/pom.xml) has 1 error
Error: 'dependencies.dependency.version' for io.quarkus:quarkus-junit5-vertx:jar is missing. @ line 109, column 17 |
|
It's the result of #23905. From the description: |
|
Got it. Thanks you. So does that mean until 2.7.3 is out this CI will fail every day? |
|
Why do you say that? CI should be green once you make the changes mentioned above. |
|
Is |
|
Nope. Isn't CI testing against Quarkus |
|
It is. Which goes to my earlier comment that I can't make any changes until 2.7.3 is released, which also means the daily CI will continue to fail each day because of it. There isn't anything I can do to fix it until 2.7.3 is out. |
|
|
|
Sounds good. Thanks for the help! Since this is a breaking change in a minor release I'd make sure it's well documented in the release notes :) |
|
Yup, will do |
|
The build is still failing:
|
|
The build is still failing:
|
|
I just merged in changes for |
|
Build fixed:
|
Not really, but you could create a Maven extension could probably do it, but IMHO, that might obscure what is going on. If you just want to test the same project with one lib (reactive), and run the build again to test it out with another (non-reactive) you could create profiles, and run the build twice: If you want to run a build and test the integration of both libraries in the same build you could do that too, but how it's structured may depend on how your project is laid out (and it's goals, e.g. if the goal is testing or explaining to others how they should test a typical app).
If that doesn't help (or I'm way off on what you are trying to do) let me know and we can chat for a few minutes, and I see if I can point you in the right direction! |
|
Thanks for chiming in @bdemers! The issue here is that in Quarkus itself, version 3.9+ renamed So now the build of the application fails. We were trying to figure out a clever way for the application to enforce the placeholders, which can be easily done in Gradle :) |
|
Ahh! Changing a GAV is hard! Depending on what you did for the placeholder redirects, (Maven empty maven modules, or actual maven repository relocation files) My suggestion would be to keep an empty module using the old name, that depends on the new name, add a deprecated note in the pom (nobody will read it though). We had a similar story with JJWT. 🤔 Another idea would be to deploy an empty jar with an odd version name like |
|
Thanks a lot for the insight @bdemers. Just for completeness I'll add that we did have relocations for the artifact in question, but those were removed since we don't want to maintain them forever. |
|
The build is still failing:
|
|
The build is still failing:
|
|
The build is still failing:
|
|
The build is still failing:
|
|
Unfortunately, the build failed:
|
|
The build is still failing:
|
|
Build fixed:
|
|
Unfortunately, the build failed:
|
|
The error looks very weird. I'll wait and see if it fixes itself tomorrow. |
|
The build is still failing:
|
|
The build is still failing:
|
|
@geoand There must be something going on. I'm at an event until Friday, so probably won't have time to troubleshoot until then. |
|
Same here |
|
The build is still failing:
|
|
The build is still failing:
|
|
@geoand I can reproduce this locally. Seems to be an issue with kotlin and/or grpc? The grpc plugin runs and generates the code but then I get all these compile errors in the generated code: Its using Here is one of the classes that was generated: // Generated by the protocol buffer compiler. DO NOT EDIT!
// source: locationservice-v1.proto
// Generated files should ignore deprecation warnings
@file:Suppress("DEPRECATION")
package io.quarkus.sample.superheroes.location.grpc;
@kotlin.jvm.JvmName("-initializeallLocationsRequest")
public inline fun allLocationsRequest(block: io.quarkus.sample.superheroes.location.grpc.AllLocationsRequestKt.Dsl.() -> kotlin.Unit): io.quarkus.sample.superheroes.location.grpc.AllLocationsRequest =
io.quarkus.sample.superheroes.location.grpc.AllLocationsRequestKt.Dsl._create(io.quarkus.sample.superheroes.location.grpc.AllLocationsRequest.newBuilder()).apply { block() }._build()
/**
* Protobuf type `io.quarkus.sample.superheroes.location.v1.AllLocationsRequest`
*/
public object AllLocationsRequestKt {
@kotlin.OptIn(com.google.protobuf.kotlin.OnlyForUseByGeneratedProtoCode::class)
@com.google.protobuf.kotlin.ProtoDslMarker
public class Dsl private constructor(
private val _builder: io.quarkus.sample.superheroes.location.grpc.AllLocationsRequest.Builder
) {
public companion object {
@kotlin.jvm.JvmSynthetic
@kotlin.PublishedApi
internal fun _create(builder: io.quarkus.sample.superheroes.location.grpc.AllLocationsRequest.Builder): Dsl = Dsl(builder)
}
@kotlin.jvm.JvmSynthetic
@kotlin.PublishedApi
internal fun _build(): io.quarkus.sample.superheroes.location.grpc.AllLocationsRequest = _builder.build()
}
}
@kotlin.jvm.JvmSynthetic
public inline fun io.quarkus.sample.superheroes.location.grpc.AllLocationsRequest.copy(block: `io.quarkus.sample.superheroes.location.grpc`.AllLocationsRequestKt.Dsl.() -> kotlin.Unit): io.quarkus.sample.superheroes.location.grpc.AllLocationsRequest =
`io.quarkus.sample.superheroes.location.grpc`.AllLocationsRequestKt.Dsl._create(this.toBuilder()).apply { block() }._build()
It also seems like its now generating both Java & Kotlin classes with the same name...
@cescoffier ^^^ |
|
I guess #44552 could the culprit? |
|
I think you're right. Following that PR, if I set |
|
I created #46675 |
This issue will be open and closed dependent on the state of https://github.com/quarkusio/quarkus-super-heroes building against Quarkus main snapshot.
If you have interest in being notified of this subscribe to the issue.
Closing #23425 in favor of this one.
The text was updated successfully, but these errors were encountered: