Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Elasticsearch dev service to its own Maven module #25486

Open
yrodiere opened this issue May 10, 2022 · 2 comments
Open

Move Elasticsearch dev service to its own Maven module #25486

yrodiere opened this issue May 10, 2022 · 2 comments
Labels
area/elasticsearch area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/maven

Comments

@yrodiere
Copy link
Member

Description

Dev services for databases all have their own module under extensions/devservices. Elasticsearch propbably should, as well.

Implementation ideas

No response

@yrodiere yrodiere added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label May 10, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented May 10, 2022

/cc @gsmet, @loicmathieu, @quarkusio/devtools

@yrodiere
Copy link
Member Author

While we're at it, we could also be more consistent with dev services for databases when it comes to the default image.

Elasticsearch dev services use a version hardcoded in their configuration class:

This is odds with the more sophisticated solutions we have for relational datasources, which relies on a properties file using interpolation to inject Maven properties:

.parse(imageName.orElseGet(() -> ConfigureUtil.getDefaultImageNameFor("postgresql")))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/elasticsearch area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/maven
Projects
None yet
Development

No branches or pull requests

1 participant