Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta - EE 10 - Gradle annotation processor test failing #28005

Closed
gsmet opened this issue Sep 16, 2022 · 3 comments · Fixed by #28072
Closed

Jakarta - EE 10 - Gradle annotation processor test failing #28005

gsmet opened this issue Sep 16, 2022 · 3 comments · Fixed by #28072
Assignees
Milestone

Comments

@gsmet
Copy link
Member

gsmet commented Sep 16, 2022

The Gradle annotation processor tests are failing in the jakarta-rewrite branch:

io.quarkus.gradle.AnnotationProcessorMultiModuleTest.shouldRunTestCorrectly line 17
io.quarkus.gradle.AnnotationProcessorSimpleModuleTest.shouldRunTestCorrectly line 18
io.quarkus.gradle.AnnotationProcessorSimpleModuleTest.shouldContainsPanacheMarkerFile line 27
io.quarkus.gradle.devmode.AnnotationProcessorMultiModuleDevModeTest.main line 13
io.quarkus.gradle.devmode.AnnotationProcessorSimpleModuleDevModeTest.main line 13

The tests are complaining about a javax.enterprise.context.ApplicationScoped class not being found but I can't find any of these remaining in the source code. The Gradle plugin doesn't give any indication of the failing class but my guess is that Mapstruct generates classes with the javax package.
I don't see any jakarta-ready Mapstruct version so I would recommend we switch these tests to an annotation processor that is not producing classes using javax packages being moved to jakarta.
This change should be made in the main branch.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 16, 2022

/cc @glefloch, @quarkusio/devtools

@gsmet
Copy link
Member Author

gsmet commented Sep 16, 2022

@glefloch could you have a look at that one?

See https://github.com/quarkusio/quarkus/tree/main/jakarta#build-locally for reproducing the issue locally.

Just do a full quickly build and then try to run the AnnotationProcessorMultiModuleTest specifically.

@glefloch
Copy link
Member

Sure I will replace mapstruct by something else

Repository owner moved this from Todo to Done in Quarkus Roadmap/Planning Sep 20, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 20, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.4.Final Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants