Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore tests of Dev UI page content for Hibernate extensions following the switch to the new Dev UI #31970

Closed
yrodiere opened this issue Mar 20, 2023 · 4 comments · Fixed by #34090
Closed

Restore tests of Dev UI page content for Hibernate extensions following the switch to the new Dev UI #31970

yrodiere opened this issue Mar 20, 2023 · 4 comments · Fixed by #34090
Labels
area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/persistence OBSOLETE, DO NOT USE
Milestone
3.2.0.CR1

Comments

@yrodiere
Copy link
Member

Description

See integration-tests/devmode/src/test/java/io/quarkus/test/devconsole/DevConsoleHibernateOrmSmokeTest.java and other Hibernate-related tests.

See https://github.com/quarkusio/quarkus/pull/31946/files#diff-a2c77b179a0ebbc7a5838f9ea5bf0cdd50c77b92299017a82ab4e022ca28d3e1R45

Yes, the plan is to use playwrite

Implementation ideas

No response
@yrodiere yrodiere added area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/housekeeping Issue type for generalized tasks not related to bugs or enhancements labels Mar 20, 2023
@quarkus-bot quarkus-bot bot added the area/persistence OBSOLETE, DO NOT USE label Mar 20, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 20, 2023

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm)

@yrodiere yrodiere mentioned this issue Mar 20, 2023
Merged
@yrodiere
Copy link
Member Author

yrodiere commented Jun 2, 2023

Hey @phillip-kruger , any news on using playwrite for Dev UI testing? Just so I know if we can consider restoring the Hibernate Dev UI tests.

@phillip-kruger
Copy link
Member

No new yet, maybe @ia3andy can help here....

@ia3andy
Copy link
Contributor

ia3andy commented Jun 5, 2023

@yrodiere the tricky part with Playwright is to setup the CI, they have their own images with the drivers and all.

@phillip-kruger phillip-kruger mentioned this issue Jun 19, 2023
Merged
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone Jun 20, 2023
@yrodiere yrodiere mentioned this issue Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Milestone
3.2.0.CR1
Development

Successfully merging a pull request may close this issue.

Dev UI Testing phillip-kruger/quarkus
3 participants
@yrodiere @ia3andy @phillip-kruger