Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev UI: Migrate OIDC to the new Dev UI #32031

Closed
phillip-kruger opened this issue Mar 22, 2023 · 20 comments · Fixed by #33653
Closed

Dev UI: Migrate OIDC to the new Dev UI #32031

phillip-kruger opened this issue Mar 22, 2023 · 20 comments · Fixed by #33653
Assignees
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/oidc
Milestone

Comments

@phillip-kruger
Copy link
Member

Description

@sberyozkin would you have time to look at this ?

Implementation ideas

No response

@phillip-kruger phillip-kruger added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Mar 22, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 22, 2023

/cc @pedroigor (oidc)

@phillip-kruger phillip-kruger mentioned this issue Mar 22, 2023
56 tasks
@sberyozkin
Copy link
Member

Hi Phillip, I honestly don't know when I'll have a chance to look into it, but I'll try to do it sooner rather later and ping you once I (inevitably) get stuck :-)

@gsmet
Copy link
Member

gsmet commented Mar 22, 2023

@melloware would you be interested in helping us porting some of the core extensions to the new Dev UI?

@melloware
Copy link
Contributor

No problem. I didn't want to step on any toes but if you send me a list of any ones you want me to tackle I would be happy to take a look!

I did have one ready for Caffeine but never submitted it.

@phillip-kruger
Copy link
Member Author

Awesome ! Thanks @melloware . You can see the outstanding list here: #31315

@gsmet
Copy link
Member

gsmet commented Mar 22, 2023

@melloware I think OIDC, Liquibase and Qute could be good candidates. If you start working on something, please add a comment in #31315 and we will update the description to make sure people are aware you're working on them.

@melloware
Copy link
Contributor

Thanks will do!

@sberyozkin
Copy link
Member

@phillip-kruger I'll try to sort it out during the next two weeks, I might ping you to clarify a few bits, from what I understand, I'll have to replace the current

  • custom template which registers an OIDC card (there we have a dynamic Provider: <MyProvider> part)
  • the main template showing the actual SPA
  • POST Handlers

@phillip-kruger
Copy link
Member Author

Ok, I also planned to start looking at this, but it would be better if you own it

@michalvavrik
Copy link
Member

Hey @sberyozkin , let me have a look into this one, I have a time and interest :-)

@sberyozkin
Copy link
Member

Hey @michalvavrik thanks Michal, if you'd like we can try to work together on this one, let me summarize here a bit later. with links, what, in OIDC DevServices, will need to be migrated, and we can try to coordinate/ I can answer all the questions, cheers

@michalvavrik
Copy link
Member

sounds good to me @sberyozkin

@michalvavrik
Copy link
Member

michalvavrik commented Apr 17, 2023

I've suggestion @sberyozkin , but please follow whatever process you prefer (summarize etc.). I had a look and I think without extra difficulties I can:

  1. migrate old OIDC DEV UI components to new DEV UI as is (Qute, appearance, functionalities)
  2. for dev-templates/provider.html js scripts leverage Vaadin as it seems that it could simplify and reduce code that handles DOM and remote calls (will see..)

then I can open draft PR and we can iterate together in areas you will want to improve/change.

@sberyozkin
Copy link
Member

Hi @michalvavrik Sounds great to me, thanks

@phillip-kruger
Copy link
Member Author

@michalvavrik how is this going, do you need help?

@michalvavrik
Copy link
Member

michalvavrik commented May 2, 2023

@phillip-kruger I don't need a help, migration is pretty easy (I'm finishing stuff on web component, the rest is done), but I didn't really have spare time in last 2 weeks so things are slower. I'll be done by Friday, then I'm sure Sergey will ask for some adjustments so we will iterate.

@phillip-kruger
Copy link
Member Author

Great ! Thanks !

@michalvavrik
Copy link
Member

Update on current state @sberyozkin - I'm yet to finish grant type password and client_credentials scenarios, plan to do that on Wednesday. If you are in real hurry, ping me and I can push link you to what I have.

@michalvavrik
Copy link
Member

blocked by #33235

@sberyozkin
Copy link
Member

Hi @michalvavrik, apologies I missed your ping, thanks a million for keeping looking at this migration, I think as long as we can have it migrated in time for 3.2.0, for Phililip to have time to remove old DevUI, it should be fine. So please take your time, if we can get finalised in time for 3.1.0..Final then it would be grand, otherwise 3.2.0.Final would be ok
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/oidc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants