-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resteasy reactive kotlin serialization not completely configured after generating app from code.quarkus.io #33622
Comments
/cc @FroMage (resteasy-reactive), @Sgitario (resteasy-reactive), @evanchooly (kotlin), @geoand (kotlin,resteasy-reactive), @stuartwdouglas (resteasy-reactive) |
Makes perfect sense, thanks for reporting! |
Had a short look and it seems this also happens with gradle, should I open a seperate ticket for that? |
No need, this ticket is fine |
cc @ia3andy |
@ia3andy given how many people use Kotlin in Quarkus, I think this should be done. WDYT? |
@geoand @janpk would it be a problem to have this dep (even when the kotlin serialization extension is not there)?: <dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-maven-serialization</artifactId>
<version>${kotlin.version}</version>
</dependency> Else we could add a "if" condition based on the selected extensions, but this is a bit fragile (same for gradle I guess) |
As far as I can tell, the issue is about configuring the Kotlin plugin, not about adding a dependency |
ah yes I missed than one: <compilerPlugins>
<plugin>all-open</plugin>
<plugin>kotlinx-serialization</plugin>
</compilerPlugins> So it's both, then we will need a if I believe |
are those two extensions the trigger to having this config? |
correct! |
Hi, team |
I will fix it now |
Describe the bug
Creating an app through code.quarkus.io with
do not configure the kotlin-maven-plugin to use kotlinx-serialization.
Without doing this, kotlin serialization will not work, and the following error will be given when returning an object where content type is application_json
Expected behavior
When selecting the resteasy reactive kotlin serialization extension, the kotlin-maven-plugin should also be configured in pom.xml.
Actual behavior
The generated kotlin-maven-plugin in pom.xml is without the kotlinx.serialization plugin
How to Reproduce?
Running
./mvnw test
results in
Output of
uname -a
orver
No response
Output of
java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: