Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot reload: the sources encoding used during recompilation should be dynamic #3486

Closed
gwenneg opened this issue Aug 12, 2019 · 0 comments · Fixed by #3487
Closed

Hot reload: the sources encoding used during recompilation should be dynamic #3486

gwenneg opened this issue Aug 12, 2019 · 0 comments · Fixed by #3487
Assignees
@gwenneg
Labels
area/devmode kind/bug Something isn't working
Milestone
0.21.0

Comments

@gwenneg
Copy link
Member

gwenneg commented Aug 12, 2019 •
edited
Loading

Describe the bug
Since #3467 got fixed, we're using a hardcoded UTF-8 encoding during a hot reload compilation.

Expected behavior
Ideally, the encoding should come dynamically from the project.build.sourceEncoding Maven property or a Gradle equivalent.
@gwenneg gwenneg added the kind/bug Something isn't working label Aug 12, 2019
@gwenneg gwenneg self-assigned this Aug 12, 2019
@gwenneg gwenneg mentioned this issue Aug 12, 2019
Merged
@gsmet gsmet added this to the 0.21.0 milestone Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gwenneg gwenneg

Labels
area/devmode kind/bug Something isn't working
Projects
None yet
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

Use a dynamic sources encoding during a hot reload compilation gwenneg/quarkus
2 participants
@gsmet @gwenneg