-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL typesafe client - support for @OidcClientFilter #35878
Comments
/cc @jmartisk (graphql), @pedroigor (oidc), @phillip-kruger (graphql), @sberyozkin (oidc) |
Hi @rmanig Current OidcClientFilter is HTTP centric, I believe there should be a Quarkus GraphQL specific interceptor which will do the same what what OIDC Client Reactive filter does here - just extend the core OIDC client code but set the token using GraphQL mechanism, except that in case of GraphQL it will be a concrete class. A non-reactive version can be created. I can help Jan or yourself to clarify the details if such an option will be implemented |
I'll try to make some time for this soon and have a look.. I think we'll need a reactive as well as non-reactive variant, and create some way to pass headers into the GraphQL client config as an Uni. We don't use any interceptors per se in GraphQL clients |
Hey Jan, you can probably limit it to the preferred reactive option |
Right, it will use the reactive client, but will block waiting for the token |
Thanks for having a look! I would love to help, but I'm not really sure if I'm able to or where to start in the graphql-client. |
I'm assuming this will require a whole new extension, just like we have two extensions for the REST client filters... Unless we want to add the OIDC client as a direct dependency of the GraphQL client extension, which we probably don't. |
FYI I have a working prototype but it needs a lot of polishing, and tests, if it goes well I might have some PRs ready by the end of the week |
Description
Hi there!
I would like to use the graphql typesafe client in combination with oidc tokens. The current static options to set and use an (authorization) header seem to be too limited for the temporary short-lived access tokens.
Are there any plans to support the
io.quarkus.oidc.client.filter.OidcClientFilter
for example? Which would handle token refreshing as well.Thanks in advance!
Implementation ideas
No response
The text was updated successfully, but these errors were encountered: