Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection of the deployer doesn't work as expected #36325

Closed
gsmet opened this issue Oct 6, 2023 · 1 comment · Fixed by #36566
Closed

Selection of the deployer doesn't work as expected #36325

gsmet opened this issue Oct 6, 2023 · 1 comment · Fixed by #36566
Assignees
Milestone

Comments

@gsmet
Copy link
Member

gsmet commented Oct 6, 2023

See #36320 (comment) .

Our code is buggy and comparing a String to an enum, thus always returning false.

@iocanel I think you wanted to either compare with e.name() or e.extension. I'm not completely sure about the fix as I'm a bit unsure of how you handle knative. I don't see an extension for it so I suppose you would have kubernetes instead and that knative can't really be identified this way?

If so, it might be better to drop .map(d -> strip(d.getArtifactId())) entirely and compare on the extension rather than the name.

I will let you have a look.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 6, 2023

/cc @geoand (knative,kubernetes), @iocanel (knative,kubernetes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants