Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vert.x gets blocked for ordered task execution when quarkus.thread-pool.queue-size is set #36530

Closed
ahus1 opened this issue Oct 17, 2023 · 4 comments
Labels
area/vertx kind/bug Something isn't working

Comments

@ahus1
Copy link
Contributor

ahus1 commented Oct 17, 2023

Describe the bug

The configuration option quarkus.thread-pool.queue-size can be used to make the Quarkus executor thread pool reject threads. I use it for load tests of Keycloak for load shedding in an overload situation.

Due to eclipse-vertx/vert.x#4900 this can lead to the Vert.x TasksQueue to be permanently blocked, when an ordered task is submitted and it is rejected.

This issue is for tracking the current behavior which is included in Vert.x 4.4.x in the current versions of Quarkus. It will be part of the upcoming Vert.x 4.5.0 version (eclipse-vertx/vert.x#4904), and I've asked for backport to 4.4.x (eclipse-vertx/vert.x#4912).

Expected behavior

When setting quarkus.thread-pool.queue-size, the task execution shouldn't stall.

Actual behavior

The task execution is stalled until the Quarkus application is restarted as a variable is not cleared when the rejected exception is thrown.

How to Reproduce?

See eclipse-vertx/vert.x#4900. For Keycloak, this happend when I called MutinyHelper.blockingExecutor(vertx) - see keycloak/keycloak#23919

Quarkus version or git rev

3.2.6.Final

@cescoffier
Copy link
Member

Unfortunately, the fix is only for Vert.x 4.5. I cannot tell when 4.5 will be integrated in Quarkus, unlikely this year.

@ahus1
Copy link
Contributor Author

ahus1 commented Oct 17, 2023

Thank you @cescoffier - that's good to know.

I've created a backport for Vert.x 4.4.x here eclipse-vertx/vert.x#4912 - let's see if it gets accepts and when there will be a another 4.4.x release.

@ahus1
Copy link
Contributor Author

ahus1 commented Nov 4, 2023

Update: The backport to 4.4.x has been accepted, but there is currently no planned release for a Vert.x 4.4.x release until more changes accumulate.

@cescoffier
Copy link
Member

Closed - Vert.x has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertx kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants