Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus JTA has not needed Dependency to ejb-api #36882

Closed
wwwaldemar opened this issue Nov 6, 2023 · 4 comments · Fixed by #36950
Closed

Quarkus JTA has not needed Dependency to ejb-api #36882

wwwaldemar opened this issue Nov 6, 2023 · 4 comments · Fixed by #36950
Labels
area/narayana Transactions / Narayana kind/bug Something isn't working
Milestone

Comments

@wwwaldemar
Copy link

wwwaldemar commented Nov 6, 2023

Even if Quarkus is not en EJB Container, it has ejb-api dependency in the classpath

Please remove it because we have e.g. two @Startup Annotations in classpath one from ejb and one from quarkus, which is error prone

[INFO] │ │ ├─ org.jboss.narayana.jta:narayana-jta:jar:7.0.0.Final (compile)
[INFO] │ │ │ ├─ org.jboss:jboss-transaction-spi:jar:8.0.0.Final (compile)
[INFO] │ │ │ ├─ jakarta.resource:jakarta.resource-api:jar:2.1.0 (compile)
[INFO] │ │ │ ├─ org.jboss.invocation:jboss-invocation:jar:2.0.0.Final (compile)
[INFO] │ │ │ ├─ jakarta.ejb:jakarta.ejb-api:jar:4.0.1 (compile)

Expected behavior

no ejb-api in classpath

Actual behavior

ejb-api is in classpath

How to Reproduce?

  • add narayana jta dependency
  • call mvn quarkus:dependency-tree
  • in the output find the ejb-api dependecy

Output of uname -a or ver

maven 3.9

Output of java -version

Temurin-21.0.1+12

Quarkus version or git rev

3.5.0

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.9.3

Additional information

No response

@wwwaldemar wwwaldemar added the kind/bug Something isn't working label Nov 6, 2023
@wwwaldemar wwwaldemar changed the title Quarkus JTA has Dependency to ejb-appi Quarkus JTA has Dependency to ejb-api Nov 6, 2023
@wwwaldemar wwwaldemar changed the title Quarkus JTA has Dependency to ejb-api Quarkus JTA has redundant Dependency to ejb-api Nov 6, 2023
@wwwaldemar wwwaldemar changed the title Quarkus JTA has redundant Dependency to ejb-api Quarkus JTA has not needed Dependency to ejb-api Nov 6, 2023
@geoand geoand added area/narayana Transactions / Narayana and removed triage/needs-triage labels Nov 6, 2023
Copy link

quarkus-bot bot commented Nov 6, 2023

/cc @mmusgrov (narayana)

@marcosgopen
Copy link
Contributor

Thanks for reporting this @wwwaldemar. We are going to change jakarta.ejb:jakarta.ejb-api:jar:4.0.1 scope to test. I will soon link the PR.

@mmusgrov
Copy link
Contributor

mmusgrov commented Nov 8, 2023

@marcosgopen We should do that but it will require a release of narayana so the immediate fix is to add an exclusion in extensions/narayana-jta/runtime/pom.xml where we depend on org.jboss.narayana.jta:narayana-jta:

                <exclusion>
                    <groupId>jakarta.ejb</groupId>
                    <artifactId>jakarta.ejb-api</artifactId>
                </exclusion>

@marcosgopen
Copy link
Contributor

@marcosgopen We should do that but it will require a release of narayana so the immediate fix is to add an exclusion in extensions/narayana-jta/runtime/pom.xml where we depend on org.jboss.narayana.jta:narayana-jta:

                <exclusion>
                    <groupId>jakarta.ejb</groupId>
                    <artifactId>jakarta.ejb-api</artifactId>
                </exclusion>

Thanks Mike! I opened the PR here.

@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/narayana Transactions / Narayana kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants