3.2.8.Final causing failure in ServerSentEventsTraceOpentracingIT in quarkus-qe/quarkus-test-suite #36979
Comments
|
/cc @brunobat (opentelemetry,tracing), @radcortez (opentelemetry,tracing) |
|
@rsvoboda the test is passing on my machine: [INFO] Running io.quarkus.ts.monitoring.opentracing.reactive.grpc.ServerSentEventsTraceOpentracingIT
[WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.005 s -- in io.quarkus.ts.monitoring.opentracing.reactive.grpc.ServerSentEventsTraceOpentracingIT
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1
[INFO]
[INFO]
[INFO] --- failsafe:3.2.2:verify (default) @ monitoring-opentracing-reactive-grpc ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25.710 s
[INFO] Finished at: 2023-11-09T15:27:22Z
[INFO] ------------------------------------------------------------------------
|
|
You need to switch to 3.2 branch as described in How to Reproduce? ;) |
|
I would bet on #35990 . |
|
Thanks @rsvoboda I was able to reproduce it. |
|
Just tried with 3.4.1 where that change was introduced but for a different failure |
|
@aloubyansky you need to be on 3.2 or 3.3, it has mixed resteasy classic and reactive, starting with 3.4 the build is aborted, before there was just a warning |
|
8449c98 - Don't ignore empty SSE events in client ... this one looks suspicious, checking now |
|
Test module is using quarkus-rest-client-reactive and quarkus-resteasy-mutiny |
|
Can we run the same test against 3.4.1 though? |
Nope, because the build fails due to mixture of resteasy reactive classic + reactive rest client. In main branch of the TS this test is disabled because RESTEasy Reactive + SSE + OpenTracing are not friends, works with OpenTelemetry. |
|
FYI, OpenTracing is deprecated and will no longer be part of the core extensions after 3.6. |
|
Either we find a backportable fix for for it or we revert 8449c98 |
|
cc @geoand |
|
I switched 8449c98 says So I can confirm that in 3.2.8.Final we have consistent behaviour :) I will check what can be changed in test to make it running on 3.2.8.Final. But any hint from @geoand would be welcome. I don't think we need to revert the change, it was triggered by GH issue. |
|
I don't see anything wrong with the app or anything that could be done on the app side. changing So I thing the scenario is hitting some SSE limitation or issue in RESTEasy Classic. And there is no easy switch to RESTEasy Reactive because OpenTracing is replaced by OpenTelemetry. |
|
I remembered conversation I had with @cescoffier about SSE with Seems the only remaining option is to disable the test and close this :) Other suggestions? |
|
Personally I am for not spending any extra time on anything SSE related in RESTEasy Classic. |
|
About SSE and RESTEasy Classic issues - shouldn't this be mentioned in our docs? And also adding a note into https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.2 that if people are using SSE with quarkus-resteasy-mutiny and quarkus-rest-client-reactive they may encounter some troubles with 3.2.8.Final and the suggested mitigation is to use RESTEasy Reactive instead of RESTEasy Classic |
|
That probably makes sense |
|
It sometimes fails randomly. I don't know the pattern. |
|
@rsvoboda should we close this? |
|
I think so, OpenTracing is deprecated |
Describe the bug
3.2.8.Final causing failure in ServerSentEventsTraceOpentracingIT in quarkus-qe/quarkus-test-suite
This test passes with 3.2.7.Final and prior versions.
Expected behavior
ServerSentEventsTraceOpentracingIT test passes
Actual behavior
ServerSentEventsTraceOpentracingIT test fails
How to Reproduce?
3.2branchmvn clean verify -f monitoring/opentracing-reactive-grpc -Dit.test=ServerSentEventsTraceOpentracingIT#testServerClientTrace -Dquarkus.platform.version=3.2.8.FinalThis test passes with 3.2.7.Final and prior versions.
Output of
uname -aorvermacOS
Output of
java -versionJava 17
Quarkus version or git rev
3.2.8.Final
Build tool (ie. output of
mvnw --versionorgradlew --version)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: