We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I've read the OTEL spec and there it says that HTTP client span names SHOULD be {method}... But it also says that:
{method}
Instrumentation MUST NOT default to using URI path as span name, but MAY provide hooks to allow custom logic to override the default span name.
A while back we already had Common URL Template path handling for client REST requests (https://github.com/quarkusio/quarkus/pull/17676/files#diff-7ec5f78d8d81fbcc3f6ddfbbaebd02aabf6bf0a843693411d955bdeba8a1d74eR56)... So can we maybe add a config parameter to change the behavior to the old way of creating rest client span names?
Having the name as {method} {urlPathTemplate} helps a lot while browsing the spans through the traces UI...
{method} {urlPathTemplate}
As right now everything (all rest clients in a app) are grouped as the HTTP methods (GET, POST, PUT....)
GET
POST
PUT
No response
The text was updated successfully, but these errors were encountered:
/cc @brunobat (opentelemetry), @cescoffier (rest-client), @geoand (rest-client), @radcortez (opentelemetry)
Sorry, something went wrong.
This was fixed on the server but not in the client...
Oh, so it wasn't on purpose that it was removed? If that is the case I can tackle this if you would like 😁
Please do @luneo7 🙏
luneo7
Successfully merging a pull request may close this issue.
Description
I've read the OTEL spec and there it says that HTTP client span names SHOULD be
{method}
...But it also says that:
A while back we already had Common URL Template path handling for client REST requests (https://github.com/quarkusio/quarkus/pull/17676/files#diff-7ec5f78d8d81fbcc3f6ddfbbaebd02aabf6bf0a843693411d955bdeba8a1d74eR56)... So can we maybe add a config parameter to change the behavior to the old way of creating rest client span names?
Having the name as
{method} {urlPathTemplate}
helps a lot while browsing the spans through the traces UI...As right now everything (all rest clients in a app) are grouped as the HTTP methods (
GET
,POST
,PUT
....)Implementation ideas
No response
The text was updated successfully, but these errors were encountered: