Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate vault client from okhttp to the quarkus rest client #4162

Closed
vsevel opened this issue Sep 23, 2019 · 0 comments · Fixed by #14319
Closed

Migrate vault client from okhttp to the quarkus rest client #4162

vsevel opened this issue Sep 23, 2019 · 0 comments · Fixed by #14319
Assignees
Labels
area/vault kind/enhancement New feature or request
Milestone

Comments

@vsevel
Copy link
Contributor

vsevel commented Sep 23, 2019

Description
The Vault extension uses okhttp to connect to vault. It would be much better to rely on the default quarkus jax-rs client.
This feature request is related to #2897 (comment) and #2897 (comment).
The rest client must be usable from cdi beans (such as VaultKvService) and the vault config source. The challenge is that the jax-rs client requires configuration to be initialized, and so using the quarkus rest client from the config source gets us in an infinite recursive loop.
Once we can use the rest client from the config source, we will be able to throw away several classes from the vault extension (OkHttpVaultClient and associated classes). It will however make us loose the ability to refer to a pem file directly (which is convenient in kubernetes), and force the use of a truststore (and add initialization complexity, such as dynamically-creating-java-keystores-openshift)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vault kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant