Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to use org.htmlunit:htmlunit #42112

Closed
rolfedh opened this issue Jul 24, 2024 · 5 comments · Fixed by #42121
Closed

Update examples to use org.htmlunit:htmlunit #42112

rolfedh opened this issue Jul 24, 2024 · 5 comments · Fixed by #42121
Assignees
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone

Comments

@rolfedh
Copy link
Contributor

rolfedh commented Jul 24, 2024

Description

@michalvavrik commented that examples with the following text should be updated to use https://mvnrepository.com/artifact/org.htmlunit/htmlunit instead:

<dependency>
    <groupId>net.sourceforge.htmlunit</groupId>
    <artifactId>htmlunit</artifactId> 

These include the following results for "net.sourceforge.htmlunit" in "*.adoc"

/home/rdlugyhe/quarkus/docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc:
1503: net.sourceforge.htmlunit
1523: testImplementation("net.sourceforge.htmlunit:htmlunit")

/home/rdlugyhe/quarkus/docs/src/main/asciidoc/security-openid-connect-multitenancy.adoc:
436: net.sourceforge.htmlunit
447: testImplementation("net.sourceforge.htmlunit:htmlunit")

fyi: @sberyozkin

Implementation ideas

No response

@rolfedh rolfedh added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jul 24, 2024
@rolfedh rolfedh self-assigned this Jul 24, 2024
@michalvavrik
Copy link
Member

for context: I made comments on 3.8 product branch, I suppose my comments are valid for 3.8 community branch, but I didn't check

@sberyozkin sberyozkin changed the title Update examples to use https://mvnrepository.com/artifact/org.htmlunit/htmlunit Update examples to use org.htmlunit:htmlunit Jul 24, 2024
@sberyozkin
Copy link
Member

@rolfedh @michalvavrik, AFAIK, the package change for HTML unit occurred in 3.12.0, #40765.
So 3.8 should continue referencing the old package.
@rolfedh Are you OK to update 2 upstream docs ? I won't really have much time, though I can try tomorrow

@michalvavrik
Copy link
Member

@rolfedh @michalvavrik, AFAIK, the package change for HTML unit occurred in 3.12.0, #40765. So 3.8 should continue referencing the old package.

Last release I can see was https://mvnrepository.com/artifact/net.sourceforge.htmlunit/htmlunit year and half ago. You are absolutely correct that Quarkus uses net.sourceforge https://github.com/quarkusio/quarkus/blob/3.8/build-parent/pom.xml#L308 but IIUC it is not managed by BOM, so I think using a newer package is not a bad idea as long as version suggested is backwards compatible to our tests.

Anyway, I can see it is hardly important, I apologize for bringing it up @rolfedh , we can probably just close it as far as 3.8 is related.

@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 24, 2024

I found a couple of instances that needed updating in main and fixed them with #42121.

@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 24, 2024

as long as version suggested is backwards compatible to our tests.

@sberyozkin @michalvavrik It's easy enough for me to make similar updates in 3.8. Just let me know what you prefer.

@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 25, 2024
@gsmet gsmet modified the milestones: 3.14 - main, 3.13.1 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants