-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support official Apache Kafka images in Kafka Dev Services #43272
Comments
/cc @alesj (kafka), @cescoffier (kafka), @geoand (devservices), @ozangunalp (kafka), @stuartwdouglas (devservices) |
I think we can add an additional dev service provider "Official" for upstream Kafka images. FYI In the original kafka-native project, we've planned to support releases until Kafka 4.0 and then deprecate the project. We'd keep the kafka-native provider for a while but not update the image. |
Agreed with @ozangunalp. My tests of the official Kafka native are not very convincing. The amount of memory it uses upfront is concerning (in comparison to Ozan's variant). We can add it as a possibility, but it won't be the default. |
That's fair. But for what it's worth, you can limit the heap size via docker run -it --rm -e "KAFKA_OPTS=-Xmx256m" apache/kafka-native:3.8.0 |
Sure, we can limit the memory, but something looks weird - it probably initialize too much or load too many classes. Our kafka-native does not need that. |
@ozangunalp, we may need to move on with this. I'm very worried about the memory issue - in a sense, it may introduce a requirement on the host machine (that needs a lot more memory). So, I would say let's add it as another option, not the default one. |
Description
Dev Services for Kafka currently supports three providers:
All of which require a slightly different setup:
quarkus/extensions/kafka-client/deployment/src/main/java/io/quarkus/kafka/client/deployment/DevServicesKafkaProcessor.java
Lines 228 to 276 in 888266f
Since Kafka 3.7.0, the Apache foundation finally publishes official container images, in both JVM and native flavor:
The
org.testcontainers:kafka
module already supports them: https://java.testcontainers.org/modules/kafka/#using-orgtestcontainerskafkakafkacontainerImplementation ideas
Add an additional
APACHE_KAFKA
provider that defaults toapache/kafka-native
. Users can override the image to use the JVM-basedapache/kafka
image if desired.Consider deprecating the
STRIMZI
andKAFKA_NATIVE
providers.The text was updated successfully, but these errors were encountered: