Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MP Metrics TCK - Fix excluded tests #4518

Closed
1 task done
kenfinnigan opened this issue Oct 11, 2019 · 3 comments · Fixed by #5742
Closed
1 task done

MP Metrics TCK - Fix excluded tests #4518

kenfinnigan opened this issue Oct 11, 2019 · 3 comments · Fixed by #5742
Labels
kind/bug Something isn't working
Milestone
1.1.0.CR1

Comments

@kenfinnigan
Copy link
Member

kenfinnigan commented Oct 11, 2019 •
edited
Loading

Currently, the below tests are excluded from execution when running the MP Metrics TCK.
@kenfinnigan kenfinnigan added the kind/bug Something isn't working label Oct 11, 2019
@jmartisk
Copy link
Contributor

GlobalTagsTest is not working due to #4512

@kenfinnigan kenfinnigan mentioned this issue Oct 18, 2019
Closed
8 tasks
@stale
Copy link

stale bot commented Nov 13, 2019

This issue/pullrequest has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 13, 2019
@maxandersen maxandersen removed the stale label Nov 13, 2019
@jmartisk
Copy link
Contributor

I just verified that after the config update (merged) and updating the MP Metrics API to 2.2.1-RC2 (locally) the TCKs pass. I will get Metrics 2.2.1 released and send a PR.

@jmartisk jmartisk mentioned this issue Nov 25, 2019
Merged
@kenfinnigan kenfinnigan added this to the 1.1.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
1.1.0.CR1
Development

Successfully merging a pull request may close this issue.

Update MP-Metrics to 2.2.1, enable GlogalTagsTest jmartisk/quarkus
3 participants
@maxandersen @kenfinnigan @jmartisk