Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve extension metrics #4675

Closed
jclingan opened this issue Oct 18, 2019 · 5 comments
Closed

Improve extension metrics #4675

jclingan opened this issue Oct 18, 2019 · 5 comments
Labels
kind/enhancement New feature or request

Comments

@jclingan
Copy link

Description
Quarkus needs a consistent approach to metrics. It would be nice for extensions to:

  1. Document not just how to enable metrics, but also document the metrics themselves
  2. Consistency (or at least formality) for enabling and exposing metrics.
  • Hibernate logs statistics (via quarkus.hibernate-orm.statistics=true property setting) to stdout but not the /metrics endpoint.
  • Kafka extension does not use a binary "true/false" metrics setting but instead it uses a metrics "level" like kafka-streams.metrics.recording.level=DEBUG. Not sure if these are logged to /metrics.
  1. I did not do an exhaustive search, only a handful of extensions (3-5) support metrics. For example, from what I can tell, there are no metrics for the web stack (REST), like number of http sessions or connections. This can make it difficult to diagnose issues in production.

Implementation ideas
None.

@jclingan jclingan added the kind/enhancement New feature or request label Oct 18, 2019
@gunnarmorling
Copy link
Contributor

gunnarmorling commented Oct 22, 2019

it uses a metrics "level" like kafka-streams.metrics.recording.level=DEBUG. Not sure if these are logged to /metrics.

Currently the Kafka Streams extension doesn't expose any health checks or metrics. There's a related discussion in #4375, which is about providing means for letting extensions automatically expose metrics and health checks if the required other extensions are enabled.

So atm. a Kafka Streams application needs a little bit of glue code for exposing these, which ultimately should be handled by the extension itself. // CC @lhauspie

@ebullient
Copy link
Member

ebullient commented Oct 14, 2020

I think some of this is changing as we switch over to micrometer: kafka instrumentation and hibernate instrumentation (and agroal.. ) all seem consistently enabled at this point.. I didn't notice some of the mentioned gaps/levels for logs vs. metrics..

@geoand
Copy link
Contributor

geoand commented Jul 29, 2021

@ebullient should this be considered done at this point?

@ebullient
Copy link
Member

Either that, or John needs to go through and make a list. ;)

@jclingan
Copy link
Author

jclingan commented Sep 1, 2021

Quarkus has come a long way since this was created. Consider this complete.

@jclingan jclingan closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants