-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated maven project should have a property for quarkus platform and version #4744
Comments
You probably want to be checking whether the platform BOM comes from Quarkus itself or it's a universe or other external one. Because if it's Quarkus core then one property will be enough. And if it's an external BOM, where else would that property be used? |
if you want to "optimize" that specific situation we could just use I'm not really following why we would have that situation occur once first platform is released and out ? |
Where would 'quarkus.platform.version' be used? |
Besides the BOM import. |
when doing |
ok |
some cleanup made it into gradle for 0.28 but both maven and gradle could use a bit more cleanup but could probably be done in a backwards compatible way. |
Describe the bug
when mvn project generated and quarkus version != platform version we fall back to hardcoded values.
Should use property replacements instead., i.e. ${quarkus.platform.version} and ${quarkus.platform.id}
To Reproduce
use latest master/0.26 with universe platform with a version number updated to be 998-SNAPSHOT in all its pom.xml files and run:
mvn io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:create -DprojectGroupId=org.acme -DprojectArtifactId=application-configuratxio557 -DclassName="org.acme.config.GreetingResource" -Dpath="/greeting" -DplatformArtifactId=quarkus-universe-bom -DplatformVersion=998-SNAPSHOT
The text was updated successfully, but these errors were encountered: