Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated maven project should have a property for quarkus platform and version #4744

Closed
maxandersen opened this issue Oct 22, 2019 · 7 comments · Fixed by #5564
Closed

Generated maven project should have a property for quarkus platform and version #4744

maxandersen opened this issue Oct 22, 2019 · 7 comments · Fixed by #5564
Assignees
Labels
area/platform Issues related to definition and interaction with Quarkus Platform kind/bug Something isn't working
Milestone

Comments

@maxandersen
Copy link
Member

Describe the bug
when mvn project generated and quarkus version != platform version we fall back to hardcoded values.
Should use property replacements instead., i.e. ${quarkus.platform.version} and ${quarkus.platform.id}

To Reproduce
use latest master/0.26 with universe platform with a version number updated to be 998-SNAPSHOT in all its pom.xml files and run:

mvn io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:create -DprojectGroupId=org.acme -DprojectArtifactId=application-configuratxio557 -DclassName="org.acme.config.GreetingResource" -Dpath="/greeting" -DplatformArtifactId=quarkus-universe-bom -DplatformVersion=998-SNAPSHOT

@maxandersen maxandersen added kind/bug Something isn't working area/platform Issues related to definition and interaction with Quarkus Platform labels Oct 22, 2019
@aloubyansky
Copy link
Member

You probably want to be checking whether the platform BOM comes from Quarkus itself or it's a universe or other external one. Because if it's Quarkus core then one property will be enough. And if it's an external BOM, where else would that property be used?

@maxandersen
Copy link
Member Author

if you want to "optimize" that specific situation we could just use <quarkus.platform.version>${quarkus.version}</quarkus.platform.version>

I'm not really following why we would have that situation occur once first platform is released and out ?

@aloubyansky
Copy link
Member

Where would 'quarkus.platform.version' be used?

@aloubyansky
Copy link
Member

Besides the BOM import.

@maxandersen
Copy link
Member Author

when doing mvn -Dquarkus.platform.version=xyz clean install to test/work with new version.

@aloubyansky
Copy link
Member

ok

@maxandersen maxandersen modified the milestones: 0.28.0, 1.0.0 Oct 29, 2019
@maxandersen
Copy link
Member Author

some cleanup made it into gradle for 0.28 but both maven and gradle could use a bit more cleanup but could probably be done in a backwards compatible way.

@maxandersen maxandersen modified the milestones: high level 1.0.0, 1.0.0.Final Nov 14, 2019
@gsmet gsmet changed the title generated maven project should have a property for quarkus platform and version Generated maven project should have a property for quarkus platform and version Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform Issues related to definition and interaction with Quarkus Platform kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants