Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides extension HealthCheck for MongoDB, Neo4j and Kafka #5073

Closed
loicmathieu opened this issue Oct 31, 2019 · 1 comment · Fixed by #5222
Closed

Provides extension HealthCheck for MongoDB, Neo4j and Kafka #5073

loicmathieu opened this issue Oct 31, 2019 · 1 comment · Fixed by #5222
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@loicmathieu
Copy link
Contributor

Description
Provides health check for some of the existing extensions.
It will not be exhaustive, please advise if some other extensions deserve an health check in the same batch of health check.

Implementation ideas

MongoDB Health Check

Provides a readiness health check for MongoDB.
Proposed implementation: use the MongoClient to list the databases.
Enabled by default.

Neo4J Health Check

Provides a readiness health check for Neo4J.
Proposed implementation: use the Bolt Driver to make a query to Neo4J.
Enabled by default.

Kafka Health Check

Provides a readiness health check for Kafka.
Proposed implementation: use the Kafka AdminClient to connect to the cluster and check it's state.
Disabled by default.

This is my opinion that as Kafka has built in resiliency for both producer and consumer, the health check should not be enabled by default. Some must have good arguments to enabled it by default and I'm open to discussion

@loicmathieu loicmathieu added the kind/enhancement New feature or request label Oct 31, 2019
@loicmathieu loicmathieu self-assigned this Oct 31, 2019
@geoand
Copy link
Contributor

geoand commented Oct 31, 2019

@cescoffier might have some comments on this

@gsmet gsmet changed the title Provides extension HealthCheck Provides extension HealthCheck for MongoDB, Neo4j and Kafka Dec 8, 2019
@gsmet gsmet added this to the 1.1.0 milestone Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants