Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending clientId/clientSecret as form params during a code flow does not work with Okta #5277

Closed
sberyozkin opened this issue Nov 7, 2019 · 4 comments · Fixed by #6749
Closed

Comments

@sberyozkin
Copy link
Member

Description
Aaron Anderson linked to this Vertx OAuth2 issue which is about the adapter duplicating the OIDC client authentication in the Authorization header by sending the same clientId and clientSecret info as the form parameters which some OIDC providers such as Okta don't like.

Implementation ideas
Introduce a configuration property to let the users specify how to post the clientId/clientSecret (Authorization header - default, form parameters - only if some providers require it) once https://github.com/vert-x3/vertx-auth/issues/319 is fixed

@sberyozkin sberyozkin added kind/enhancement New feature or request area/oidc labels Nov 7, 2019
@sberyozkin sberyozkin changed the title Block sending clientId/clientSecret as form parameters during the grant to token exchange Do not send clientId/clientSecret as form params during a grant to token exchange by default Nov 7, 2019
@sberyozkin sberyozkin changed the title Do not send clientId/clientSecret as form params during a grant to token exchange by default Sending clientId/clientSecret as form params during a code flow does not work with Okta Nov 29, 2019
@sberyozkin sberyozkin added the kind/bug Something isn't working label Nov 29, 2019
@pedroigor
Copy link
Contributor

The configuration property makes sense. I'm wondering now if that idea we discussed about having "profiles" for the different implementations make sense. Something like a quarkus.oidc.provider=keycloak|okta|auth0 to dictate the defaults for each one.

@sberyozkin
Copy link
Member Author

Hi Pedro @pedroigor, Paulo @pmlopes has just merged a fix into Vertx Oauth2.
Yeah, some kind of a grouping concept may be done as part of #4448, but that would be up to the user how to qualify the configurations, the adapter is generic so it would be simpler if if we can try to keep the configuration generic. That said, I'm not sure with the current fix the new property is needed :-), so I'll likely close the issue once Quarkus is updated to Vertx-OAuth2 3.8.5

@pmlopes
Copy link
Contributor

pmlopes commented Dec 8, 2019

Hi @sberyozkin the fix is already on 4.0.0rc5 but not backported to 3.8 branch yet (the branches are quite apart so it's not a trivial backport if no new 3.8 release is planned soon).

@sberyozkin sberyozkin added area/oidc-interoperability and removed kind/enhancement New feature or request labels Dec 11, 2019
@sberyozkin
Copy link
Member Author

@pmlopes thanks for also backporting a fix to 3.8.5-SNAPSHOT :-) I've asked at the users list to confirm it helps (I'm sure it helps :-) )

@gsmet gsmet added this to the 1.3.0 milestone Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants