Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support application/jwk-set+json content type when processing responses from JWKS Endpoint #6087

Closed
pedroigor opened this issue Dec 10, 2019 · 5 comments · Fixed by #6749
Closed

Comments

@pedroigor
Copy link
Contributor

Describe the bug
quarkus-oidc not considering the application/jwk-set+json content type when processing responses from the JWKS endpoint.

Expected behavior
Accordingly with the specs the application/jwk-set+json can be used to indicate that the content is a JWKS.

Actual behavior
Cannot handle content type: application/jwk-set+json; charset=UTF-8

To Reproduce
Steps to reproduce the behavior:

  1. Install quarkus-oidc extension
  2. Point to a OP that uses the application/jwk-set+json content type in responses from JWKS Endpoint

Configuration
N/A

Screenshots
N/A

Environment (please complete the following information):

  • v1.0.1.Final

Additional context
The issue was found when integrating with Identity Server 4.

@pedroigor pedroigor added kind/bug Something isn't working area/oidc labels Dec 10, 2019
@pedroigor
Copy link
Contributor Author

@sberyozkin @pmlopes Vert.x OAuth seems to be considering only application/json when processing JWKS responses. Does make sense to also include application/jwk-set+json in the list of valid content types ?

@sberyozkin
Copy link
Member

@pedroigor it is a standard JWK set type, so yes :-). Let me open a Vertx issue

@pedroigor
Copy link
Contributor Author

@sberyozkin btw, shall we start documenting the OPs we can integrate with ? As well as have a "interoperability" label to differentiate such issues ?

@sberyozkin
Copy link
Member

@pedroigor Good idea, right now such issues are indirectly described as such in #5874. I can add oidc-interoperability label. I'd like to retain though the option of clicking on component:oidc and seeing all the OIDC issues, so please add both labels for the interop issues

@sberyozkin
Copy link
Member

Paulo fixed it in Vertx OAuth2

@gsmet gsmet added this to the 1.3.0 milestone Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants