Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK language specific tests #7564

Closed
hartimcwildfly opened this issue Mar 4, 2020 · 6 comments · Fixed by #7680
Closed

JDK language specific tests #7564

hartimcwildfly opened this issue Mar 4, 2020 · 6 comments · Fixed by #7680
Labels
kind/bug Something isn't working
Milestone

Comments

@hartimcwildfly
Copy link

When checking out the current master branch and do a build,
some tests fail because the expected error message is in english but my system is not in english so the actual error message does not match.

Example:
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.375 s <<< FAILURE! - in io.quarkus.reactive.pg.client.ReactivePgReloadTest [ERROR] testHotReplacement Time elapsed: 5.365 s <<< FAILURE! java.lang.AssertionError: 1 expectation failed. Response body doesn't match expectation. Expected: (a string starting with "Connection refused" and a string ending with ":2345") Actual: Verbindungsaufbau abgelehnt: localhost/127.0.0.1:2345

Running maven with -Duser.language=en -Duser.country=US did not solve the problem.

@hartimcwildfly hartimcwildfly added the kind/bug Something isn't working label Mar 4, 2020
@geoand
Copy link
Contributor

geoand commented Mar 4, 2020

Hi, it would be great to have a list of such tests that fail for you

@hartimcwildfly
Copy link
Author

io.quarkus.reactive.pg.client.ReactivePgReloadTest.testHotReplacement()
io.quarkus.reactive.pg.client.LegacyReactivePgReloadTest.testHotReplacement()

@geoand
Copy link
Contributor

geoand commented Mar 4, 2020

Would you also like to provide a Pull Request that updates the tests accordingly?

@hartimcwildfly
Copy link
Author

I found a solution for UNIX systems: set the ENV_VAR: LC_ALL=en_US.UTF-8
The question is how do we integrate it into the maven project.

@geoand
Copy link
Contributor

geoand commented Mar 4, 2020

You can set env vars during command execution (simply by prepending the command with the something like NAME=VALUE mvn clean install)

@hartimcwildfly
Copy link
Author

Yup. But it would be cool to integrate into maven pom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants