Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gradle native TS #9797

Closed
aloubyansky opened this issue Jun 4, 2020 · 4 comments · Fixed by #9852
Closed

Add Gradle native TS #9797

aloubyansky opened this issue Jun 4, 2020 · 4 comments · Fixed by #9852
Assignees
@glefloch
Labels
area/gradle Gradle area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone
1.6.0.CR1

Comments

@aloubyansky
Copy link
Member

At this point our Gradle TS is missing native tests. We should add native build tests that would be enabled by -Dnative or -Pnative as the rest of the Quarkus native TS.
@aloubyansky aloubyansky added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jun 4, 2020
@aloubyansky aloubyansky mentioned this issue Jun 4, 2020
Merged
@aloubyansky aloubyansky added area/gradle Gradle and removed area/housekeeping Issue type for generalized tasks not related to bugs or enhancements labels Jun 4, 2020
@aloubyansky aloubyansky added kind/bug Something isn't working area/housekeeping Issue type for generalized tasks not related to bugs or enhancements and removed kind/bug Something isn't working labels Jun 4, 2020
@aloubyansky
Copy link
Member Author

I'm not sure why I can't assign this one to you @glefloch

@glefloch
Copy link
Member

glefloch commented Jun 4, 2020

yes that's weird but I'm on it ;)

@glefloch
Copy link
Member

glefloch commented Jun 5, 2020 •
edited
Loading

Thanks @gastaldi for the assignment.
Looking at github action, it looks like native tests are only run for module under integration-tests:

quarkus/.github/workflows/ci-actions.yml

Line 549 in e99fded

do modules+=("integration-tests/$i"); done

So I was thinking of creating a gradle module under integration-tests. WDYT of moving gradle functionalTest their ?
Or is there an easier way to add native test into the gradle module?

@gastaldi
Copy link
Contributor

gastaldi commented Jun 5, 2020

So I was thinking of creating a gradle module under integration-tests. WDYT of moving gradle functionalTest their ?

+1, I think that makes sense.

@glefloch glefloch mentioned this issue Jun 8, 2020
Merged
@gsmet gsmet added this to the 1.6.0 - master milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glefloch glefloch

Labels
area/gradle Gradle area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Milestone
1.6.0.CR1
Development

Successfully merging a pull request may close this issue.

Init gradle integration tests glefloch/quarkus
4 participants
@gastaldi @aloubyansky @gsmet @glefloch