Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update desired channel state setting to reflect a three-valued enum #174

Closed
ryan-summers opened this issue Jan 28, 2022 · 3 comments · Fixed by #183
Closed

Update desired channel state setting to reflect a three-valued enum #174

ryan-summers opened this issue Jan 28, 2022 · 3 comments · Fixed by #183
Milestone
0.3.0

Comments

@ryan-summers
Copy link
Member

ryan-summers commented Jan 28, 2022 •
edited
Loading

Update the enabled and output_disabled parameters to reflect a three-valued enum of {Off, Powered, Enabled}.

Note

If EEPROM is modified to store more than a bool enabled, the format will change and previous user settings will be lost.

It's not immediately clear of storing Powered in the channel EEPROM settings is valid.
@ryan-summers ryan-summers mentioned this issue Jan 28, 2022
Merged
1 task
@jordens
Copy link
Member

jordens commented Jan 28, 2022

Agreed. Can we convert Powered to Off on save?

@ryan-summers
Copy link
Member Author

Yeah, I think that's not a bad approach.

@jordens
Copy link
Member

jordens commented Jan 28, 2022 •
edited
Loading

Since this also affects the handling of absent channels, let's continue #170 (comment) here as well.

Maybe it's easier to add an additional field to the settings structure that explicitly marks a channel as absent.

-> #175

@jordens jordens added this to the 0.3.0 milestone Jan 28, 2022
@ryan-summers ryan-summers mentioned this issue Feb 2, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Restructuring channel power state to an enum quartiq/booster
2 participants
@jordens @ryan-summers