From fa4c19ea3bacef7764acd7d1de0d03cd98526c7f Mon Sep 17 00:00:00 2001 From: Razvan Stoenescu Date: Sat, 27 Apr 2024 11:07:02 +0300 Subject: [PATCH] feat(docs): be more specific on minimum vue-tsc version in the upgrade guide #17089 --- app-vite/lib/modes/electron/electron-builder.js | 4 ++-- app-webpack/lib/modes/electron/electron-builder.js | 4 ++-- docs/src/pages/quasar-cli-vite/linter.md | 8 ++++---- docs/src/pages/quasar-cli-vite/upgrade-guide.md | 8 ++++---- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/app-vite/lib/modes/electron/electron-builder.js b/app-vite/lib/modes/electron/electron-builder.js index f8fa712bdeb..97daed92044 100644 --- a/app-vite/lib/modes/electron/electron-builder.js +++ b/app-vite/lib/modes/electron/electron-builder.js @@ -89,12 +89,12 @@ export class QuasarModeBuilder extends AppBuilder { let content = this.readFile(npmrc) if (content.indexOf('shamefully-hoist') === -1) { - content += '\nshamefully-hoist=true' + content += '\n# needed by pnpm\nshamefully-hoist=true' } // very important, otherwise PNPM creates symlinks which is NOT // what we want for an Electron app that should run cross-platform if (content.indexOf('node-linker') === -1) { - content += '\nnode-linker=hoisted' + content += '\n# pnpm needs this otherwise it creates symlinks\nnode-linker=hoisted' } this.writeFile( diff --git a/app-webpack/lib/modes/electron/electron-builder.js b/app-webpack/lib/modes/electron/electron-builder.js index 060258b5feb..f448e62deaf 100644 --- a/app-webpack/lib/modes/electron/electron-builder.js +++ b/app-webpack/lib/modes/electron/electron-builder.js @@ -90,12 +90,12 @@ module.exports.QuasarModeBuilder = class QuasarModeBuilder extends AppBuilder { let content = this.readFile(npmrc) if (content.indexOf('shamefully-hoist') === -1) { - content += '\nshamefully-hoist=true' + content += '\n# needed by pnpm\nshamefully-hoist=true' } // very important, otherwise PNPM creates symlinks which is NOT // what we want for an Electron app that should run cross-platform if (content.indexOf('node-linker') === -1) { - content += '\nnode-linker=hoisted' + content += '\n# pnpm needs this otherwise it creates symlinks\nnode-linker=hoisted' } this.writeFile( diff --git a/docs/src/pages/quasar-cli-vite/linter.md b/docs/src/pages/quasar-cli-vite/linter.md index caa3bdc3562..042ca9aa4f3 100644 --- a/docs/src/pages/quasar-cli-vite/linter.md +++ b/docs/src/pages/quasar-cli-vite/linter.md @@ -83,13 +83,13 @@ The linting for a TS project is based on vite-plugin-checker + ESLint + vue-tsc: ```tabs <<| bash Yarn |>> -$ yarn add --dev vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0 +$ yarn add --dev vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0 <<| bash NPM |>> -$ npm install --save-dev vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0 +$ npm install --save-dev vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0 <<| bash PNPM |>> -$ pnpm add -D vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0 +$ pnpm add -D vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0 <<| bash Bun |>> -$ bun add --dev vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0 +$ bun add --dev vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0 ``` ::: warning diff --git a/docs/src/pages/quasar-cli-vite/upgrade-guide.md b/docs/src/pages/quasar-cli-vite/upgrade-guide.md index f2ac47344ae..21a08af9d5f 100644 --- a/docs/src/pages/quasar-cli-vite/upgrade-guide.md +++ b/docs/src/pages/quasar-cli-vite/upgrade-guide.md @@ -209,13 +209,13 @@ We dropped support for our internal linting (quasar.config file > eslint) in fav ```tabs <<| bash Yarn |>> -$ yarn add --dev vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0 +$ yarn add --dev vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0 <<| bash NPM |>> -$ npm install --save-dev vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0 +$ npm install --save-dev vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0 <<| bash PNPM |>> -$ pnpm add -D vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0 +$ pnpm add -D vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0 <<| bash Bun |>> -$ bun add --dev vite-plugin-checker vue-tsc@^1.0.0 typescript@~5.3.0 +$ bun add --dev vite-plugin-checker vue-tsc@^1.8.22 typescript@~5.3.0 ``` ::: warning