Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing @quasar/[email protected] fails while resolving dependencies #13784

Closed
thexeos opened this issue Jun 24, 2022 · 4 comments
Closed

Comments

@thexeos
Copy link
Contributor

thexeos commented Jun 24, 2022

What happened?

npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/vue
npm ERR!   peer vue@"^2.6.14 || ^3.2.0" from [email protected]
npm ERR!   node_modules/pinia
npm ERR!     peerOptional pinia@"^2.0.0" from @quasar/[email protected]
npm ERR!     node_modules/@quasar/app-webpack
npm ERR!       dev @quasar/app-webpack@"3.5.4" from the root project
npm ERR!   peer vue@">= 2.5 < 3" from @vue/[email protected]
npm ERR!   node_modules/@vue/composition-api
npm ERR!     peerOptional @vue/composition-api@"^1.4.0" from [email protected]
npm ERR!     node_modules/pinia
npm ERR!       peerOptional pinia@"^2.0.0" from @quasar/[email protected]
npm ERR!       node_modules/@quasar/app-webpack
npm ERR!         dev @quasar/app-webpack@"3.5.4" from the root project

What did you expect to happen?

I have [email protected] installed in the project (implicitly - it is not set in package.json). Installed version of @quasar/app-webpack is 3.5.1.

This error happens when running quasar upgrade -i as well as npm install @quasar/[email protected] directly.

Deleting node_modules and/or package-lock.json has no effect.

All other packages are latest versions or @next versions to support Webpack 5.

There is no [email protected] anywhere in package-lock.json - it is not being requested by any other package either.

Reproduction URL

https://codepen.io/alvarotrigo/pen/b

How to reproduce?

None

Flavour

Quasar CLI with Webpack (@quasar/cli | @quasar/app-webpack)

Areas

Quasar CLI Commands/Configuration (@quasar/cli | @quasar/app-webpack | @quasar/app-vite)

Platforms/Browsers

No response

Quasar info output

No response

Relevant log output

No response

Additional context

No response

@github-actions
Copy link

Hi @thexeos! 👋

It looks like you provided an invalid or unsupported reproduction URL.
Do not use any service other than Codepen, jsFiddle, StackBlitz, Codesandbox, and GitHub.
Make sure the URL you provided is correct and reachable. You can test it by visiting it in a private tab, another device, etc.
Please edit your original post above and provide a valid reproduction URL as explained.

Without a proper reproduction, your issue will have to get closed.

Thank you for your collaboration. 👏

@yusufkandemir
Copy link
Member

See #13786 (comment).

I have [email protected] installed in the project (implicitly - it is not set in package.json). Installed version of @quasar/app-webpack is 3.5.1.

You should have it directly as a dependency in your project, not "implicitly".

@rfox12
Copy link
Contributor

rfox12 commented Jun 26, 2022

I've been using Quasar for quite some time... and we've never had to include Vue as a direct dependency. This change will have a wide impact. And for the record, you avoid this dependency problem by including Vue in devDependencies

@yusufkandemir
Copy link
Member

@rfox12 that was the case since @quasar/app-v3.3.0 which got released 5 months ago. We had to externalize these dependencies to let the dev take full control of the Vue version, and adjust the compatibility of the packages they are using. Also, TS was not offering auto-import suggestions for transitive dependencies(#9235). Unless the package manager doesn't install those dependencies under the hood, then decides to stop doing that later^, running quasar dev automatically detects those dependencies are missing, and installs them. The release notes also mentions this behavior, so it's a known and documented fact. Project templates have these dependencies added by default, so new projects are not affected in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants