Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncm-iptables: Negation syntax has changed upstream #1808

Open
jrha opened this issue Jan 22, 2025 · 0 comments
Open

ncm-iptables: Negation syntax has changed upstream #1808

jrha opened this issue Jan 22, 2025 · 0 comments

Comments

@jrha
Copy link
Member

jrha commented Jan 22, 2025

This snippet:

'filter/rules' = merge(SELF, list(
    dict(
        'command', '-A',
        'chain', 'FORWARD',
        'src_addr', '! 8.8.8.8',
        'jump', 'DROP',
    ),
);

Generates the following iptables line:

-A FORWARD -s ! 8.8.8.8 -j DROP

This syntax for negation was deprecated and removed at some point in the past, it should generate:

-A FORWARD ! -s 8.8.8.8 -j DROP

It might not be worth fixing this given that we should probably be putting development effort into supporting something other than iptables, so maybe the best option is to change the documentation to state that this is no longer supported.

@jrha jrha changed the title ncm-iptable: Negation syntax has been changed ncm-iptables: Negation syntax has been changed Jan 22, 2025
@jrha jrha changed the title ncm-iptables: Negation syntax has been changed ncm-iptables: Negation syntax has changed upstream Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant