Linter: don't allow version_added === version_removed (mdn#3546)

queengooborg · Mar 8, 2019 · cc8404c · cc8404c
1 parent 06a7564
commit cc8404c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 32 deletions.
diff --git a/api/RTCPeerConnection.json b/api/RTCPeerConnection.json
@@ -305,8 +305,7 @@
               }
             ],
             "safari": {
-              "version_added": "11",
-              "version_removed": "11"
+              "version_added": null
             },
             "safari_ios": {
               "version_added": null
@@ -1521,8 +1520,7 @@
               }
             ],
             "safari": {
-              "version_added": "11",
-              "version_removed": "11"
+              "version_added": null
             },
             "safari_ios": {
               "version_added": null
@@ -1638,8 +1636,7 @@
               }
             ],
             "safari": {
-              "version_added": "11",
-              "version_removed": "11"
+              "version_added": null
             },
             "safari_ios": {
               "version_added": null
@@ -1890,8 +1887,7 @@
               }
             ],
             "safari": {
-              "version_added": "11",
-              "version_removed": "11"
+              "version_added": null
             },
             "safari_ios": {
               "version_added": null
@@ -3728,8 +3724,7 @@
               }
             ],
             "safari": {
-              "version_added": "11",
-              "version_removed": "11"
+              "version_added": null
             },
             "safari_ios": {
               "version_added": "11",

diff --git a/css/properties/custom-property.json b/css/properties/custom-property.json
@@ -197,26 +197,12 @@
               "opera": {
                 "version_added": null
               },
-              "safari": [
-                {
-                  "version_added": "11.1"
-                },
-                {
-                  "version_added": "11",
-                  "version_removed": "11",
-                  "alternative_name": "constant"
-                }
-              ],
-              "safari_ios": [
-                {
-                  "version_added": "11.1"
-                },
-                {
-                  "version_added": "11",
-                  "version_removed": "11",
-                  "alternative_name": "constant"
-                }
-              ]
+              "safari": {
+                "version_added": "11.1"
+              },
+              "safari_ios": {
+                "version_added": "11.1"
+              }
             },
             "status": {
               "experimental": true,

diff --git a/test/test-versions.js b/test/test-versions.js
@@ -48,8 +48,8 @@ function testVersions(dataFilename) {
               console.error('\x1b[31m  version_added: "' + statement.version_added + '" is not a valid version number when version_removed is present');
               console.error('  Valid', browser, 'versions are:', validBrowserVersions[browser].length > 0 ? 'true, ' + validBrowserVersions[browser].join(', ') : 'true');
               hasErrors = true;
-            } else if (typeof statement.version_added === "string" && typeof statement.version_removed === "string" && compareVersions(statement.version_added, statement.version_removed) > 0) {
-              console.error('\x1b[31m  version_added: "' + statement.version_added + '" cannot be higher than version_removed: "' + statement.version_removed + '"');
+            } else if (typeof statement.version_added === "string" && typeof statement.version_removed === "string" && compareVersions(statement.version_added, statement.version_removed) >= 0) {
+              console.error('\x1b[31m  version_removed: "' + statement.version_removed + '" must be greater than version_added: "' + statement.version_added + '"');
               hasErrors = true;
             }
           }