-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
negated props? #5
Comments
Hi, Thanks for using the library! I'm afraid I'm the one responsible for mobile and tablet being both matched at once. It's happening because the mobile prop is optimistic and matches mobile + Android or iOS detection
Will it work for you just disabling this part?
It will ensure that only one of |
@quentin-sommer I think that should work. I think the keeping the OS check separate from device type would help reduce false positives and provide flexibility for those who want those checks for their usecase. |
Fixed starting |
Hi @quentin-sommer, firstly, thank you for creating this useful library!
In a particular use-case, I was looking to target only a mobile phones, but not tablets. Unfortunately, I noticed that the
mobile
prop is set totrue
on both mobile and tablet devices.So, in such a case, what do you recommend? Would you consider adding a
false
value such that the code below would target only say mobile phones:If so, that would be useful for people who want to target only certain browsers on certain mobile devices as this would provide the desired flexibility?
Thank you!
The text was updated successfully, but these errors were encountered: