-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It shouldn't possible to save empty filter rules #51
Comments
hi @ChristianSchaefer , I understand, you are referring to the rule:
presumably you'd like to express a rule, that states: "For the managed query, the (Solr) field searchText should not be searches at all" Is that correct? The following rule definition will be positively validated by Querqy:
Although I am not sure, what will be the specified outcome of that in Querqy ( @renekrie ?), and if there is even a way to use Querqy's CommonRuleRewriter in a way, that it prevents complete fields from being searched by Solr/Lucene. Very interesting case though!! @ChristianSchaefer , it would be great to learn more about your use case intent , and wether above's suggestion works for you!? |
@pbartusch I think your solution I think @ChristianSchaefer's point is that it shouldn't be possible to save such a rule in SMUI. Overall, whatever you put in that query string is completely transparent to Querqy - it will just ask Solr to parse the query at runtime. Unfortunately, we cannot validate Lucene/Syntax 100% outside Solr. For example, the query string might use plugged in custom query parsers that we don't know about in SMUI. Also, we cannot validate that a field exists. Strictly spoken, in some cases we might not even know that a given piece of the string refers to a field. However, we should make sure that this is not a rule that was produced by SMUI, for example, when the user entered a field name in the UI without specifying any field value. |
@renekrie is right. It shouldn't be possible to save empty rules or a warning should appear, if this is a desired feature. If you save an empty rule with *, the result of the query isn't predictable, right? |
thanks @ChristianSchaefer for the report. I released v3.11.11 , that should solve the issue. |
Hi,
we had the problem, that it is possible to save empty filter rules, which leads to a syntax error, when deploying into solr.
Here is an excerpt of our rules-smt file
The text was updated successfully, but these errors were encountered: