strtod and locale

[ABBAPOH]

I have a question about how JS deals with doubles and locale.
From StackOverflow it seems that it doesn't respect the locale at all. Is this true?
Anyway, QuickJS uses strtod which is locale-aware
We've patched QuickJS with a "safe_strtod" that enforces "C" locale to avoid issues on different platforms.
However I am wondering if this should got to upstream and it it is, in which form? Maybe simply re-implement locale-unaware strtod without the need to call dreaded "locale" functions (surely there are multiple implementations on the web)

[bnoordhuis]

strtod is locale-sensitive and yes, JS is locale-insensitive, so that's a problem. Maybe not a huge problem but still.

Libraries as a rule shouldn't touch setlocale() and replacing strtod() with a homegrown thing is not trivial (musl libc's strtod is over 500 lines) so I don't know if this is actually something we'll want to fix.

[ABBAPOH]

Looking at the old PR that switched to the Bellard's version, it seems we indeed caught the problem with French locale and doubles:

quickjs.c line 10115 calls for strtod which return 1 for input 1.50 when locale is FRENCH

So it seems like a rather big-ish problem.

[chqrlie]

Relying on strtod is indeed a problem. Using custom code would be my preferred solution, for both double to string and string to double conversions. Fabrice and I have been working on a complete replacement for both strtod and printf, hence thereby reducing the libc adherence. This code it is not fully ripe yet and we have been caught up with other work in the interim.
Messing with the locale or preparing the string for strtod are not good solutions for the problem.